Date: Fri, 23 Apr 2021 09:28:34 +0900 From: Katsuyuki Miyoshi <katsu@miyoshi.matsuyama.ehime.jp> To: freebsd-users-jp@freebsd.org Subject: [FreeBSD-users-jp 96795] Re: =?iso-2022-jp?b?RnJlZUJTRDEzGyRCJEckThsoQlJJUHYy?= Message-ID: <xsr5z0dvo7h.fsf@kmgw.miyoshi.matsuyama.ehime.jp> In-Reply-To: <CACr8D6XhB1T8navjnsVUrRiqoU%2BJtxeZFUHUW4zMnSf=bFSrgw@mail.gmail.com> (Nst's message of "Thu, 22 Apr 2021 18:35:12 %2B0900") References: <CACr8D6XhB1T8navjnsVUrRiqoU%2BJtxeZFUHUW4zMnSf=bFSrgw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
$B$_$h$7(B $B$G$9!#(B Nst <nst329@gmail.com> writes: > syslog$B$r8+$?$H$3$m0J2<$N$h$&$J%(%i!<$,H/@8$7$F$$$^$9(B > --- syslog --- > Apr 22 18:20:29 host1 routed[554]: write(rt_sock) RTM_ADD 10.0.0.0 > (mask 0xffff0000)-->192.168.0.XXX metric=1 flags=0x2: Invalid argument > Apr 22 18:20:29 host1 kernel: mask sin_len too small > --- > > $B>/$78!:w$7$?$H$3$m0J2<$r8+$D$1$^$7$?(B > https://lists.freebsd.org/pipermail/dev-commits-src-branches/2021-March/001341.html > $B$3$l$N1F6A$J$N$G$7$g$&$+!)(B Bug 255273 $BJU$j$GJs9p$,$"$C$F!"(Bmain $B%V%i%s%A(B (current) $B$G$O(B ====================================================================== commit b31fbebeb3d59af359a3417cddfbcf666b2c56c9 Author: Alexander V. Chernikov <melifaro@FreeBSD.org> Date: Mon Apr 19 20:49:18 2021 +0000 Relax rtsock message restrictions. Address multiple issues with strict rtsock message validation. D28668 "normalisation" approach was based on the assumption that we always have at least "standard" sockaddr len. It turned out to be false - certain older applications like quagga or routed abuse sin[6]_len field and set it to the offset to the first fully-zero bit in the mask. It is impossible to normalise such sockaddrs without reallocation. With that in mind, change the approach to use a distinct memory buffer for the altered sockaddrs. This allows supporting the older software while maintaining the guarantee on the "standard" sockaddrs. PR: 255273,255089 Differential Revision: https://reviews.freebsd.org/D29826 MFC after: 3 days ====================================================================== $B$G4{$K=$@5$,F~$C$F$$$k$h$&$G$9!#$3$l$,%^!<%8$5$l$l$PD>$j$=$&$J5$$,$7$^$9!#(B -- $B;09%>!9,(B (Katsuyuki Miyoshi)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xsr5z0dvo7h.fsf>