From owner-svn-src-head@freebsd.org Wed Feb 24 17:53:53 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65651AB21F7 for ; Wed, 24 Feb 2016 17:53:53 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yk0-x233.google.com (mail-yk0-x233.google.com [IPv6:2607:f8b0:4002:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 34D0F1DC6 for ; Wed, 24 Feb 2016 17:53:53 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yk0-x233.google.com with SMTP id u9so11188185ykd.1 for ; Wed, 24 Feb 2016 09:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=29xvUeuMTdRdkAgKqeki+rSy4yndfil7iUDRHMh1ZCI=; b=oCRwPGxBz+wvmrywxBowgYTmvKt7D7xhccbenhoVxU8HWQGFANFHAF5BiCXXwIVoxh pRoJ8CkUPZSlqWNMBhOo0M6UyXVyY9vl1ZJdR55DvTGtjT7d0B0AOTqaXXuBFu0D7xEg ctydQVPIYgVp7EEqTDU9RmqmNNCBOPLuvv5eT36nP7qJUcuXUDvmWkEqzKlGphNwc/Lt xs8IavMviOkb5JXwiisIfG36KEscxHHqyNeePB4PjbaY8E7iHp5W1n3sWaOH0LcgpXgT ll8E8OjUP9QpP1dwiwavwIFKzOH/qSkqxr8yWZQTRV/ry5yC7eYE6U/+ak7jqZHJbSg7 7/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=29xvUeuMTdRdkAgKqeki+rSy4yndfil7iUDRHMh1ZCI=; b=fv9PRYJn603h+OH30SD89HQIcMu/RfNh2Ao6cj1rMAZ6FtDGX9nIMC1BewyJeNaenG +uM28SYkqWZA4mvQZC0J0tr/mGa71B/RLoPY2fFkeSybqC705lF7myEqnEevkUgngNtB 7pFmClFkHvMhL7Mh4V3TbAdRaDdZonmt0LNCGjzIBkgEeoz/nfeU5OXJzjkcvpGa93WG lrHnhPElIAzVKENbkbu0+AXwNvX4wGOAKfY7B6V23v6mt30Hfy6v85FUCOHyraqN+0Hk IMMPZtJ+I588IsBsJrRvAnzdn9D169NEWxR7IrT+EYxwU/8UkD+3c2eLFGcQofQll7li 8Pag== X-Gm-Message-State: AG10YORWeqTJ1NnB5IHEAzXHevZ6JlH8J1nHITsH0IyYremNHAMKv2kq/27SrokYJsuQ4KPnCid6Oi4ia9HinA== MIME-Version: 1.0 X-Received: by 10.37.78.5 with SMTP id c5mr21165414ybb.53.1456336432174; Wed, 24 Feb 2016 09:53:52 -0800 (PST) Received: by 10.129.148.6 with HTTP; Wed, 24 Feb 2016 09:53:52 -0800 (PST) In-Reply-To: <56CDE508.5000903@multiplay.co.uk> References: <201602241710.u1OHAWwM086142@repo.freebsd.org> <56CDE508.5000903@multiplay.co.uk> Date: Wed, 24 Feb 2016 18:53:52 +0100 Message-ID: Subject: Re: svn commit: r295974 - head/sys/kern From: Ed Schouten To: Steven Hartland Cc: Ed Schouten , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 17:53:53 -0000 Hi Steven, 2016-02-24 18:14 GMT+01:00 Steven Hartland : > This should really be commented to this effect in the code otherwise someone > reading the source will think its a mistake. Good point. I also looked at the code a bit more and it looks like we now call unp_drop() with errno == ECONNRESET unconditionally, meaning we can simplify the code a bit. What do you think of the following patch? http://80386.nl/pub/20160224-socket-econnreset.txt Thanks, -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717