From owner-freebsd-fs@FreeBSD.ORG Tue Jan 14 20:18:01 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 984574C5 for ; Tue, 14 Jan 2014 20:18:01 +0000 (UTC) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) by mx1.freebsd.org (Postfix) with ESMTP id 584C81185 for ; Tue, 14 Jan 2014 20:18:01 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1W3AQy-000Imq-Iq; Wed, 15 Jan 2014 00:18:00 +0400 Date: Wed, 15 Jan 2014 00:18:00 +0400 From: Slawa Olhovchenkov To: Johan Hendriks Subject: Re: zfs locking Message-ID: <20140114201800.GS16734@zxy.spb.ru> References: <20140114133642.GM16734@zxy.spb.ru> <52D543B7.2010407@FreeBSD.org> <20140114141347.GN16734@zxy.spb.ru> <52D59642.6070007@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52D59642.6070007@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false Cc: freebsd-fs@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 20:18:01 -0000 On Tue, Jan 14, 2014 at 08:55:46PM +0100, Johan Hendriks wrote: > Slawa Olhovchenkov schreef: > > On Tue, Jan 14, 2014 at 04:03:35PM +0200, Andriy Gapon wrote: > > > >> on 14/01/2014 15:36 Slawa Olhovchenkov said the following: > >>> DTRACE_PROBE2(l2arc__read, vdev_t *, vd, > >>> zio_t *, rzio); > >>> ARCSTAT_INCR(arcstat_l2_read_bytes, // arc_read+2137 > >>> hdr->b_l2hdr->b_asize); > >>> > >>> if (*arc_flags & ARC_NOWAIT) { > >>> zio_nowait(rzio); > >>> return (0); > >>> } > >>> > >>> ASSERT(*arc_flags & ARC_WAIT); > >>> if (zio_wait(rzio) == 0) > >>> return (0); > >>> > >>> /* l2arc read error; goto zio_read() */ > >>> > >>> Is this locking issue? > >> This looks like a bug that was already fixed in illumos and FreeBSD head. > >> What version of FreeBSD do you use? > >> See r258388 and r258389. > > 10.0-BETA1 > > > > I don't see commit to 10.x > > _______________________________________________ > > freebsd-fs@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > I think that at that time HEAD was FreeBSD 10, FreeBSD 11 was created > later on. > If you look at the source, you can see that these fixes are in the > source of 10.0 10 fork at r256279, before this fixes.