From owner-freebsd-bugs@FreeBSD.ORG  Sat Jan  8 16:00:55 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 285F016A4DE
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  8 Jan 2005 16:00:55 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6BC3B43D7E
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  8 Jan 2005 16:00:53 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j08G0rxi076987
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 8 Jan 2005 16:00:53 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j08G0rF1076979;
	Sat, 8 Jan 2005 16:00:53 GMT
	(envelope-from gnats)
Resent-Date: Sat, 8 Jan 2005 16:00:53 GMT
Resent-Message-Id: <200501081600.j08G0rF1076979@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Finn <zero@gddn.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 59A2E16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  8 Jan 2005 15:56:25 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4760943D1F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  8 Jan 2005 15:56:25 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j08FuOqM090865
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 8 Jan 2005 15:56:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j08FuOfm090864;
	Sat, 8 Jan 2005 15:56:24 GMT
	(envelope-from nobody)
Message-Id: <200501081556.j08FuOfm090864@www.freebsd.org>
Date: Sat, 8 Jan 2005 15:56:24 GMT
From: Finn <zero@gddn.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: bin/75946: cosmetic typo in /etc/rc.subr: check_pidfile()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Jan 2005 16:00:55 -0000


>Number:         75946
>Category:       bin
>Synopsis:       cosmetic typo in /etc/rc.subr: check_pidfile()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 08 16:00:52 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Finn
>Release:        CURRENT RELENG_5 RELENG_5_3
>Organization:
>Environment:
>Description:
In /etc/rc.subr there is a '(' vs. '{' typo in the function check_pidfile() line 206. Since it appears in a debug message in 
double quotes, it has no effect on functionality.

>How-To-Repeat:

>Fix:
--- etc/rc.subr,~
+++ etc/rc.subr
@@ -192,19 +192,19 @@
 check_pidfile()
 {
 	_pidfile=$1
 	_procname=$2
 	_interpreter=$3
 	if [ -z "$_pidfile" -o -z "$_procname" ]; then
 		err 3 'USAGE: check_pidfile pidfile procname [interpreter]'
 	fi
 	if [ ! -f $_pidfile ]; then
 		debug "pid file ($_pidfile): not readable."
 		return
 	fi
 	read _pid _junk < $_pidfile
 	if [ -z "$_pid" ]; then
-		debug "pid file {$_pidfile): no pid in file."
+		debug "pid file ($_pidfile): no pid in file."
 		return
 	fi
 	_find_processes $_procname ${_interpreter:-.} '-p '"$_pid"
 }

>Release-Note:
>Audit-Trail:
>Unformatted: