From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 31 14:10:12 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 517941065672 for ; Wed, 31 Aug 2011 14:10:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 400458FC14 for ; Wed, 31 Aug 2011 14:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p7VEACsM001102 for ; Wed, 31 Aug 2011 14:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p7VEACJd001101; Wed, 31 Aug 2011 14:10:12 GMT (envelope-from gnats) Date: Wed, 31 Aug 2011 14:10:12 GMT Message-Id: <201108311410.p7VEACJd001101@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: "Conrad J. Sabatier" Cc: Subject: Re: ports/160012: [maintainer-update] [patch] net-p2p/lopster portlint cleanup X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Conrad J. Sabatier" List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2011 14:10:12 -0000 The following reply was made to PR ports/160012; it has been noted by GNATS. From: "Conrad J. Sabatier" To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/160012: [maintainer-update] [patch] net-p2p/lopster portlint cleanup Date: Wed, 31 Aug 2011 08:53:13 -0500 --MP_/+315PFIPi7AuoTOu6tFPOcb Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline I've further revised this port to incorporate the following changes: 1) Move CPPFLAGS out of the CONFIGURE_ENV variable, as per portlint 1) Convert all of the "ad hoc" WITH* variable handling to use the standard OPTIONS scheme instead, and ensure that LIB_DEPENDS are all declared. 2) Remove the post-patch: target (which did a few sed substitutions) and add patch files in its place. 3) Rename the non-standard patch file patch-src::global.c to patch-src-global.c to conform to conventions for patch filenames. I believe this should be the final set of changes needed to bring this port into full compliance with port standards. Conrad J. Sabatier [lopster.diff attached] --MP_/+315PFIPi7AuoTOu6tFPOcb Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=lopster.diff Index: Makefile =================================================================== RCS file: /home/ncvs/ports/net-p2p/lopster/Makefile,v retrieving revision 1.44 diff -u -r1.44 Makefile --- Makefile 13 Aug 2011 06:47:33 -0000 1.44 +++ Makefile 31 Aug 2011 12:34:13 -0000 @@ -7,7 +7,7 @@ PORTNAME= lopster PORTVERSION= 1.2.2 -PORTREVISION= 8 +PORTREVISION= 9 CATEGORIES= net-p2p MASTER_SITES= SF \ http://lopster.sourceforge.net/download/ @@ -19,35 +19,33 @@ USE_GMAKE= yes USE_GNOME= gtk12 CONFIGURE_ARGS= --with-pthread=yes -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib" +CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib" +CPPFLAGS+= "-I${LOCALBASE}/include" + +OPTIONS= FLAC "Include FLAC support" On \ + OGG "Include OGG support" On \ + ZLIB "Enable ZLIB compression" On .include +.include -.if exists(${LOCALBASE}/lib/libogg.so.7) -WITH_OGG= yes +# --with-flac is on by default +.if defined(WITH_FLAC) +LIB_DEPENDS+= FLAC.10:${PORTSDIR}/audio/flac +.else +CONFIGURE_ARGS+= --without-flac .endif +# --with-ogg is on by default .if defined(WITH_OGG) -LIB_DEPENDS+= ogg.7:${PORTSDIR}/audio/libogg -.endif - -.if !defined(WITHOUT_ZLIB) -CONFIGURE_ARGS+= --with-zlib=yes +LIB_DEPENDS+= ogg.7:${PORTSDIR}/audio/libogg .else -CONFIGURE_ARGS+= --with-zlib=no +CONFIGURE_ARGS+= --without-ogg .endif -pre-everything:: -.ifndef WITH_OGG - @${ECHO_MSG} "You can specify WITH_OGG to include Ogg support" -.endif -.ifndef WITHOUT_ZLIB - @${ECHO_MSG} "You can specify WITHOUT_ZLIB to disable compression for old servers" +# --with-zlib is on by default +.if defined(WITHOUT_ZLIB) +CONFIGURE_ARGS+= --without-zlib .endif -post-patch: - @${REINPLACE_CMD} -e "s|-lpthread|${PTHREAD_LIBS}|g" ${WRKSRC}/configure - @${REINPLACE_CMD} -e "s/www.naplist.com/www.gotnap.com/" \ - ${WRKSRC}/src/lopster.h - .include Index: files/patch-configure =================================================================== RCS file: files/patch-configure diff -N files/patch-configure --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-configure 31 Aug 2011 11:13:22 -0000 @@ -0,0 +1,20 @@ +--- configure.orig 2004-08-29 13:38:43.000000000 -0500 ++++ configure 2011-08-31 06:08:59.000000000 -0500 +@@ -2245,14 +2245,14 @@ + if eval "test \"`echo '$ac_cv_header_'$ac_safe`\" = yes"; then + echo "$ac_t""yes" 1>&6 + +- echo $ac_n "checking for pthread_attr_init in -lpthread""... $ac_c" 1>&6 +-echo "configure:2250: checking for pthread_attr_init in -lpthread" >&5 ++ echo $ac_n "checking for pthread_attr_init in ${PTHREAD_LIBS}""... $ac_c" 1>&6 ++echo "configure:2250: checking for pthread_attr_init in ${PTHREAD_LIBS}" >&5 + ac_lib_var=`echo pthread'_'pthread_attr_init | sed 'y%./+-%__p_%'` + if eval "test \"`echo '$''{'ac_cv_lib_$ac_lib_var'+set}'`\" = set"; then + echo $ac_n "(cached) $ac_c" 1>&6 + else + ac_save_LIBS="$LIBS" +-LIBS="-lpthread $LIBS" ++LIBS="${PTHREAD_LIBS} $LIBS" + cat > conftest.$ac_ext <