From owner-svn-src-head@freebsd.org Wed Dec 4 03:47:31 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 21A1A1C7F3F; Wed, 4 Dec 2019 03:47:31 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47SPtp2GxDz4LHn; Wed, 4 Dec 2019 03:47:30 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x343.google.com with SMTP id s14so6252343wmh.4; Tue, 03 Dec 2019 19:47:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7hf0LcIgjZXclHUI512QfeKQ7YRrTp611H7xgct+S6A=; b=uX2rh/np1LXu1tgp0xD9VnFWxipWMzoz3zzUERZMd83o363p8ncjj/b1dsOA1PNncv lhxVSyxOcOMtYX7pfMNd5DbEM9pzvsg3MZkoBbi//c9qI7A/z8iecpMgmVg2bakC51Pr GW0t2kAUno1cvRDZK23HvWfRQJVz44BW9Ktv0gc0yqjDPlV7FXEEbdVBdqgaC+4jhCe9 mYv6FwJEElHi77pTwaeCQLpf8YOa9+KSuzfwPxuh7nmDZf9uu+a1iN9ytNIRLJUAoVVk gyeJp7puaaDI8A4/gsLPi/AM0QOcKgTSY7c01WGrKhqNOFa8wEzZktTTkxn4T0ZgZcEJ bd5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7hf0LcIgjZXclHUI512QfeKQ7YRrTp611H7xgct+S6A=; b=CEO04RB4nCGdU7lHsWPIzV96xf3HWBMIVXddcbo9iShqgTBLDVc2ECuEKYeOJtXskd BPiXYp/GbddrPAioTD7C4PfmToWljWM3bOVZT+OzcjfqFdSACw3wdS4nMteY1GfougIn 2uXFXi/ErYJcAiHIMaIaU3HYNnLfJuzMqXEZ4QY0f9rNEceSoYV2FEddDkH1e/+qwCBs eByjR41fMHtuFZXw9iCRjDD4AqJKmZuJFY0pNW7aEdeMQZuGXRMFpUTgy9VfEUfSkLgB J5Pna0w+4gaBiXlQZNWmUN9jHR9513GObnSgf3Alef7iM3ZrSs/bSDVBlWBIIRE3GEut tsSw== X-Gm-Message-State: APjAAAX4Hcqe0vWqgOk1j/62tNEco1AENGzyfxfVenBs7xJjV6IrGZkS DJQ2C2eCGdfkRXvZriD0jFgVYHJ/FmQvC2togJUyLA== X-Google-Smtp-Source: APXvYqyqcGWqOIAZUEBV17IvdrFwmhgeDojggcsDS7k2OiRYVAh3i46+1OgzlzcTvFtlJnQyUHdx9zh/d+jo+pqupA8= X-Received: by 2002:a1c:2e91:: with SMTP id u139mr32995357wmu.154.1575431247695; Tue, 03 Dec 2019 19:47:27 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:9ed0:0:0:0:0:0 with HTTP; Tue, 3 Dec 2019 19:47:27 -0800 (PST) In-Reply-To: <6cd7168c-8212-3001-fb8f-09ecaca93e61@FreeBSD.org> References: <201911301933.xAUJX2DB030548@repo.freebsd.org> <6cd7168c-8212-3001-fb8f-09ecaca93e61@FreeBSD.org> From: Mateusz Guzik Date: Wed, 4 Dec 2019 04:47:27 +0100 Message-ID: Subject: Re: svn commit: r355241 - head/sys/kern To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47SPtp2GxDz4LHn X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=uX2rh/np; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; IP_SCORE(0.00)[ip: (3.07), ipnet: 2a00:1450::/32(-2.69), asn: 15169(-1.93), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[3.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Dec 2019 03:47:31 -0000 On 12/2/19, John Baldwin wrote: > On 11/30/19 11:33 AM, Mateusz Guzik wrote: >> Author: mjg >> Date: Sat Nov 30 19:33:02 2019 >> New Revision: 355241 >> URL: https://svnweb.freebsd.org/changeset/base/355241 >> >> Log: >> smp: cast the read in quiesce_all_critical through void * >> >> Fixes compilation on some 32-bit arm platforms. >> >> Sponsored by: The FreeBSD Foundation >> >> Modified: >> head/sys/kern/subr_smp.c >> >> Modified: head/sys/kern/subr_smp.c >> ============================================================================== >> --- head/sys/kern/subr_smp.c Sat Nov 30 19:21:29 2019 (r355240) >> +++ head/sys/kern/subr_smp.c Sat Nov 30 19:33:02 2019 (r355241) >> @@ -952,7 +952,7 @@ quiesce_all_critical(void) >> break; >> cpu_spinwait(); >> newtd = (struct thread *) >> - atomic_load_acq_ptr((u_long *)pcpu->pc_curthread); >> + atomic_load_acq_ptr((void *)pcpu->pc_curthread); > > Why not uintptr_t *? I think that's the defined type for atomic_*_ptr > anyway? > I have no strong opinion one way or the other. However, the real fix would make these routines work without casting for cases like the above. -- Mateusz Guzik