From owner-cvs-ports@FreeBSD.ORG Fri Dec 9 15:50:02 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0378A1065675; Fri, 9 Dec 2011 15:50:01 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.57]) by mx1.freebsd.org (Postfix) with ESMTP id A73B48FC1C; Fri, 9 Dec 2011 15:50:01 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76) (envelope-from ) id 1RZ2he-0004eN-Pf; Fri, 09 Dec 2011 19:49:38 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 6212EB866; Fri, 9 Dec 2011 19:49:38 +0400 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 8FD5BE06; Fri, 9 Dec 2011 19:49:40 +0400 (MSK) Date: Fri, 9 Dec 2011 19:49:40 +0400 From: Dmitry Marakasov To: Max Brazhnikov Message-ID: <20111209154940.GA77124@hades.panopticon> References: <201111101950.pAAJoQOb072790@repoman.freebsd.org> <20111209005145.GA1551@hades.panopticon> <201112091310.18922.makc@issp.ac.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201112091310.18922.makc@issp.ac.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, Raphael Kubo da Costa , ports-committers@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.cmake.mk X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2011 15:50:02 -0000 * Max Brazhnikov (makc@issp.ac.ru) wrote: > > > Remove CMAKE_USE_PTHREAD. > > > > > > This has been in area51 since April, and discussions with makc > > > indicate this was only needed when we supported FreeBSD < 7. > > > > > > Approved by: avilla (mentor), portmgr (tabthorpe) > > > Feature safe: yes > > > > > > Revision Changes Path > > > 1.13 +1 -15 ports/Mk/bsd.cmake.mk > > > > This has broken at least devel/bullet. This is not feature safe at all. > > Can you show the build log? http://people.freebsd.org/~amdmi3/bullet_default.log with LDFLAGS=-pthread it builds fine: http://people.freebsd.org/~amdmi3/bullet_ldflags.log Likely that's a correct way to fix it as bullet CMakeLists.txt doesn't do any attempts to detect/use thread libs, however the point is that cited commit is not safe and may touch more ports. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru