From owner-svn-src-head@freebsd.org Tue Aug 30 19:03:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19D44BC9899 for ; Tue, 30 Aug 2016 19:03:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D734EF7B for ; Tue, 30 Aug 2016 19:03:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22f.google.com with SMTP id i184so335862itf.1 for ; Tue, 30 Aug 2016 12:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=7b4MxZbIPbE1Od76zFPlPic5vESCLZHA3WCiDasN7Ow=; b=SfwqyrG6YwTZo9pZA31rCK6ep260u45ovArKqBJifSj4UWlDtozSGbE8oTMiMK1MdX 9VXH+7by1oh5ObOO2ntKrOY6NlHCZxvmgUaxnWBzaCor4PD23bPGrVMLJvwwXkL3CcTV SpVAbEMHSIEEslkZ6raAnN6qhfw1mq1qWxUgFLn/w8csUmjb7SoDHc1DNmQ+496bI+SB H3df6OebT+0kPmEbodqmsPqBSakgu7QJhBbnZztOH/T2wFuFKwuT+rRv+AFr3R0o7qrX +Teyb6tbMuEEoiiFrbafZxLk3LfbuHWT/Ho0JBWzO/iVHWFYSTyKSi7IYjcXuIbUkDpS cMDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=7b4MxZbIPbE1Od76zFPlPic5vESCLZHA3WCiDasN7Ow=; b=IqHt+U7uFcUhyi2KQYA36FXqVwbGiMnvUvH/hCjI3U7rHpFnY5TBaUv2Fxn6QSeltd OkJsFoAGKmB/fJ/NJR9jYVfeu06KQYvucFtGdVD1Q1NHTU/ngi1T2UAYJXLoMl1+hurg MIfSBJI3q0UKWBNhAp76XLrhKNv0h8R48WWlx2tzEseUdiQ8yhUQjoUyw9WNVS61T4JB buzgISq7BrPu7gqZSKLlQQUaHD5ydKYGfls+Zfclsg2m+LzoXItcK7k3XyvNBEwLj5us MWfCb9WLEY36Uep9CEyfxmnjCM2QQeu8fV/EaqefVZV7MhbBDBuOnaZdLSqXHMmDgPTS FvZA== X-Gm-Message-State: AE9vXwOE+lmYNnTBSKyZvkIob18UHxe6MYfaAL5teHXnZ1AwTJyM3lUCAikPVUvTRFtCIMR4595uoDz8Qyizhg== X-Received: by 10.107.53.142 with SMTP id k14mr746389ioo.59.1472583816152; Tue, 30 Aug 2016 12:03:36 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.65.7 with HTTP; Tue, 30 Aug 2016 12:03:35 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: <1531680.3M3PdubIRh@ralph.baldwin.cx> References: <201608292247.u7TMlEf3050457@repo.freebsd.org> <1531680.3M3PdubIRh@ralph.baldwin.cx> From: Warner Losh Date: Tue, 30 Aug 2016 13:03:35 -0600 X-Google-Sender-Auth: vJLpho0TMSXB9DHaeCgvsuTX7xE Message-ID: Subject: Re: svn commit: r305032 - head/sys/dev/cxgbe To: John Baldwin Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 19:03:37 -0000 On Tue, Aug 30, 2016 at 8:22 AM, John Baldwin wrote: > On Monday, August 29, 2016 10:47:14 PM John Baldwin wrote: >> Author: jhb >> Date: Mon Aug 29 22:47:14 2016 >> New Revision: 305032 >> URL: https://svnweb.freebsd.org/changeset/base/305032 >> >> Log: >> Use device_verbose() to undo device_quiet() when detaching from t[45]iovX. >> >> The device quiet flag is not automatically reset on detach, so it is >> inherited by other device drivers (e.g. when switching a device driver >> over to ppt for PCI pass through). Cope with this behavior by explicitly >> marking the device verbose during detach so that the next driver can make >> its own decision. >> >> Sponsored by: Chelsio Communications > > Even though device_quiet() is documented to work this way, I think it is probably > worth considering changing this so it only affects a single attach/detach life > cycle. That is, clearing the flag in device_detach() (but also handling > device_probe() correctly since it is typically called during probe and if > multiple drivers probe a device, you only want the behavior of the "winning" > driver to be in effect when you call attach). I concur. Years ago, I had something like this in my tree, but I had a disk failure before I could push it in :( Warner