Date: Tue, 30 Aug 2016 13:03:35 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r305032 - head/sys/dev/cxgbe Message-ID: <CANCZdfr-K0gSWd0joo4nx3BZHR=_F3adkS_c2c%2Bf0BqYv=O4yQ@mail.gmail.com> In-Reply-To: <1531680.3M3PdubIRh@ralph.baldwin.cx> References: <201608292247.u7TMlEf3050457@repo.freebsd.org> <1531680.3M3PdubIRh@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 30, 2016 at 8:22 AM, John Baldwin <jhb@freebsd.org> wrote: > On Monday, August 29, 2016 10:47:14 PM John Baldwin wrote: >> Author: jhb >> Date: Mon Aug 29 22:47:14 2016 >> New Revision: 305032 >> URL: https://svnweb.freebsd.org/changeset/base/305032 >> >> Log: >> Use device_verbose() to undo device_quiet() when detaching from t[45]iovX. >> >> The device quiet flag is not automatically reset on detach, so it is >> inherited by other device drivers (e.g. when switching a device driver >> over to ppt for PCI pass through). Cope with this behavior by explicitly >> marking the device verbose during detach so that the next driver can make >> its own decision. >> >> Sponsored by: Chelsio Communications > > Even though device_quiet() is documented to work this way, I think it is probably > worth considering changing this so it only affects a single attach/detach life > cycle. That is, clearing the flag in device_detach() (but also handling > device_probe() correctly since it is typically called during probe and if > multiple drivers probe a device, you only want the behavior of the "winning" > driver to be in effect when you call attach). I concur. Years ago, I had something like this in my tree, but I had a disk failure before I could push it in :( Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr-K0gSWd0joo4nx3BZHR=_F3adkS_c2c%2Bf0BqYv=O4yQ>