Date: Thu, 18 Aug 2016 17:26:11 +0000 From: Shivansh Rai <shivansh@freebsd.org> To: hiren panchasara <hiren@strugglingcoder.info>, Peter Sewell <Peter.Sewell@cl.cam.ac.uk> Cc: "freebsd-transport@freebsd.org" <freebsd-transport@freebsd.org>, "Jonathan T. Looney" <jtl@freebsd.org>, Sam Kumar <samkumar99@gmail.com> Subject: Re: TCP_HAVERCVDFIN Message-ID: <CAF%2Bp1Ht_1hSbtFV%2BiFpUNC_GMgFG=dYKs9s63VRmCrUKofv7nQ@mail.gmail.com> In-Reply-To: <CAF%2Bp1Ht=ES4n6OOS-EKNjCfjqGetMVQk0jtY_-vtK==Nc3pUSQ@mail.gmail.com> References: <CAGtMfeBWzGAmt2Kq9bejon54xiz%2BHBOEjho1z=NZe_0fqG5Z2g@mail.gmail.com> <D2B685A4.4F28E%jlooney@juniper.net> <CAHWkzRSvofzDoH-W6kkhr_JexjbWQkfvN5sX-Ws5NPM-_XhYDQ@mail.gmail.com> <20160817235158.GE68615@strugglingcoder.info> <CAF%2Bp1Ht=ES4n6OOS-EKNjCfjqGetMVQk0jtY_-vtK==Nc3pUSQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, I deeply apologize for my mistake. The tests which I have made do not test the intended behavior, as I misunderstood the issue which was being discussed. Hiren has pointed out how to go about testing the issue, so I will update the tests soon. Thank you. Regards, Shivansh Rai On Thu, Aug 18, 2016 at 7:13 PM Shivansh Rai <shivanshrai84@gmail.com> wrote: > Hi Hiren, > > I have updated the test suite *[1]* with the relevant tests *[2]* that > were pointed out in D7475 *[3]*. I hope they can be used for the > verification. > Please let me know in case of any discrepancies. > > [1] : https://github.com/shivrai/TCP-IP-Regression-TestSuite > [2] : > https://github.com/shivrai/TCP-IP-Regression-TestSuite/tree/master/fin > [3] : https://reviews.freebsd.org/D7475 > > Thank you. > With Best Regards, > Shivansh Rai > > On Thu, Aug 18, 2016 at 5:22 AM hiren panchasara < > hiren@strugglingcoder.info> wrote: > >> Resurrecting this thread. >> >> https://reviews.freebsd.org/D7475 >> >> I like this new behavior and it is being tested at NF and LLNW without >> any known problems. >> >> Any strong objection against it other than it _may_ break something? :-) >> I don't see us getting a conformance test suite anytime soon so I >> suggest we go ahead with this fix without any MFC and see how it goes? >> >> Cheers, >> Hiren >> > -- > Regards, > Shivansh Rai >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF%2Bp1Ht_1hSbtFV%2BiFpUNC_GMgFG=dYKs9s63VRmCrUKofv7nQ>