From nobody Wed Jul 29 12:46:57 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h9BtC6fxSz6nBvV; Wed, 29 Jul 2026 12:46:59 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h9BtC61HLz3twc; Wed, 29 Jul 2026 12:46:59 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785329219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+GjNqWjPi39a6qt66hDLnUpTbAIQy/g+HSIPlnIRsVI=; b=hC7eTjwuZiUfnC8nMpP3ozo9OddfjGBD64PJfKu5NaN/0c3YL5OxApRX2coK3iCcsjc3Y1 pi4EB1TMC9hwpuv5FbO0SwrgR6FoZ8eYhlERWCPXajMrP/b8MroqM5+S/WO08aLeRLFMaB 9j1uxsa1MnrFCktU0vZm9EPvzk7qZzE75gnSbvrRvtOQgJQ5tQ7851eIVPvEHRP1TgzKyp HHWspb5cm7N3cUsPLPJ634IdDgSds0AHZxmm/XySSrSkCIS48NqLHdCXvZTVY9nWlraZGL ciM4aNIPYGLySD9PH8MMkdFIjoX0pGF6DNSf+K5G3d+/RutfSudlqTgERRakVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785329219; a=rsa-sha256; cv=none; b=MY4L/6oqHXghojgnorQmA9XfoFkpN035DJlvbI5k65JIitwi6G0F8eFHUjToF+PN52u/Rw KohwFcZRRxDbZgueMfZYLQp+HVDXUlLqzpWZxx7MZwAME2P5sav0QrOOdpoGWrvjpMUfhs 3qDsgWni3omQVaqo+e0tlqS7B6TVOeeDbcbAIxgFUqgd1Wj5nTRginsUZD9ud5GK5krt/n f+OgjtM5RGvMB8ks1aUbyP8AITKrkTfZOEwzX9hzxD78kJt/YmEFWoelY/l66lFCA36T/G 1cdhrTHblY+lyvu3x7MFdjajAeT5F1JKHNDB5pZnWUsmX1S6fy10skDJD488Jw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785329219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+GjNqWjPi39a6qt66hDLnUpTbAIQy/g+HSIPlnIRsVI=; b=UmHxVthqM4W4Iyqz2NbZPUiXLpuHmaZYCH+P6pN6UsaR7n2ZSUBhKSFm97cQHhKmDHkai/ 4lHG/HWQYARrTsxTxEVgCFVqKEoMUrD+JTTSzZnYJDwbzO852PhqgU7JLtyk2YQrfYaJuo z9desG01nPNR8G/RmOnZnP67WJE1s1oLrYxCofsj8h4ProkuRiDxl4/FBcaufNsRu59NrL qbcKrWL6BU0+26Q4PrKIkWDt9vYXyz53htyaZn6CQsNBCx3L0dJyek9GG323knITgKkRYb BBljBNK1b0vE2dPmpHpRJm9WfMRvLd7U5ABRlHa2QmYVz09zbjM4DBphOuZ5GA== Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4h9BtC3Cf7zt5H; Wed, 29 Jul 2026 12:46:59 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Wed, 29 Jul 2026 08:46:57 -0400 From: Mark Johnston To: Kevin Bowling Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1f4b0ea4f3eb - main - kqueue: Add a helper macro for sleeping on in-flux knotes Message-ID: References: <6a67e66f.32351.45a31bd3@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jul 29, 2026 at 04:05:43AM -0700, Kevin Bowling wrote: > Hi Mark, > > This is resulting in relatively easy to trigger panic with 'syncthing' > running under INVARIANTS: > panic: kqueue_scan: knote 0xfffffe018aeab930 not on kqueue 0xfffff80010aa2400 > > The panic occurs at the new KASSERT in KQ_FLUX_SLEEP_WMESG(), called > from kqueue_scan() line 2197. Two Syncthing threads were concurrently > scanning the same kqueue. > > kgdb showed that the knote named in the panic was exactly the other > scanning thread’s local marker: > > &marker = 0xfffffe018aeab930 > marker.kn_status = KN_MARKER > marker.kn_kq = NULL > kq = 0xfffff80010aa2400 I just committed a change which should address this: https://cgit.freebsd.org/src/commit/?id=9a9349ea1da2d80e979fa87b430551d8f6dac7f4