Date: Mon, 2 Feb 2015 14:01:23 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Juergen Lock <nox@jelal.kn-bremen.de> Cc: Dirk Meyer <dinoex@FreeBSD.org>, svn-ports-head@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r378229 - head/sysutils/xen-tools Message-ID: <20150202130123.GJ11558@ivaldir.etoilebsd.net> In-Reply-To: <20150201115859.GA92369@enceladus10.kn-bremen.de> References: <201502010704.t1174age082281@svn.freebsd.org> <20150201073353.GA81373@FreeBSD.org> <20150201115859.GA92369@enceladus10.kn-bremen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--mPTHnM80CEnHQ2WJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 01, 2015 at 12:58:59PM +0100, Juergen Lock wrote: > On Sun, Feb 01, 2015 at 07:33:53AM +0000, Alexey Dokuchaev wrote: > > On Sun, Feb 01, 2015 at 07:04:36AM +0000, Dirk Meyer wrote: > > > New Revision: 378229 > > > URL: https://svnweb.freebsd.org/changeset/ports/378229 > > > QAT: https://qat.redports.org/buildarchive/r378229/ > > >=20 > > > Log: > > > - use full path in DEPENDS > >=20 >=20 > > Modified: head/sysutils/xen-tools/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sysutils/xen-tools/Makefile Sat Jan 31 23:32:50 2015 (r378228) > > +++ head/sysutils/xen-tools/Makefile Sun Feb 1 07:04:36 2015 (r378229) > > @@ -13,9 +13,9 @@ COMMENT=3D Xen tools within FreeBSD domU > > MASTER_SITES=3D http://bits.xensource.com/oss-xen/release/${PORTVERSIO= N}/ > > DISTFILES=3D xen-${PORTVERSION}.tar.gz > > =20 > > -BUILD_DEPENDS=3D bash:${PORTSDIR}/shells/bash \ > > - lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > - lib/ibyajl.so:${PORTSDIR}/devel/yajl > > +BUILD_DEPENDS=3D ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \ > > + ${LOCALBASE}/lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > + ${LOCALBASE}/lib/ibyajl.so:${PORTSDIR}/devel/yajl > > =20 > > USES=3D gmake python:configure perl5 gettext-runtime:build gettext-to= ols:build pkgconfig > > USE_PERL5=3D build >=20 >=20 > > But why? What's the reason behind this change? > >=20 > > ./danfe > >=20 > I guess he meant... >=20 > > -BUILD_DEPENDS=3D bash:${PORTSDIR}/shells/bash \ > > - lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > - lib/ibyajl.so:${PORTSDIR}/devel/yajl > > +BUILD_DEPENDS=3D bash:${PORTSDIR}/shells/bash > > +LIB_DEPENDS=3D libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > + ibyajl.so:${PORTSDIR}/devel/yajl >=20 > Cheers, > Juergen >=20 Which would be wrong as well because xen-tools startically uses those dependencies. So it does not depend on any.so it depends on a .a, meaning the right fix h= ere would be to use BUILD_DEPENDS=3D ${LOCALBASE}/libglib-2.0.a and not the .so Bapt --mPTHnM80CEnHQ2WJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlTPdSMACgkQ8kTtMUmk6Ex9OQCfVtFNTa79kTUz5IleNCdw/uer +pUAn30AzChh9hfSfDE7l1iZcAmygJVt =DnP6 -----END PGP SIGNATURE----- --mPTHnM80CEnHQ2WJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150202130123.GJ11558>