From owner-svn-src-all@freebsd.org Sun Feb 7 01:04:42 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F3F4A9F824; Sun, 7 Feb 2016 01:04:42 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id E563F1A15; Sun, 7 Feb 2016 01:04:41 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 72DAEDCFA; Sun, 7 Feb 2016 01:04:35 +0000 (UTC) Subject: Re: svn commit: r295357 - head/sys/boot/zfs To: Warner Losh References: <201602070049.u170nFBo047492@repo.freebsd.org> Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Allan Jude Message-ID: <56B69836.7020709@freebsd.org> Date: Sat, 6 Feb 2016 20:04:54 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oIovhPnoVQVmm6SgU5xLvIvKc5cGgQ9Lj" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2016 01:04:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oIovhPnoVQVmm6SgU5xLvIvKc5cGgQ9Lj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-02-06 19:55, Warner Losh wrote: >=20 >=20 > On Sat, Feb 6, 2016 at 5:49 PM, Allan Jude > wrote: >=20 > Author: allanjude > Date: Sun Feb 7 00:49:15 2016 > New Revision: 295357 > URL: https://svnweb.freebsd.org/changeset/base/295357 >=20 > Log: > Do not set vfs.root.mountfrom unnecessarily >=20 > This causes boot from external media (installer USB image) to > mount / from > the default ZFS BE, rather than the USB device. >=20 >=20 > Sure this didn't just break zfs booting? >=20 > Warner > =20 I tested in in a VM and on two laptops. The var was only being set if it was not already set by loader.conf, and only to provide a 'default' for the 'Active' item in the ZFS BE Menu. The system will derive the default root mountpoint from the loader 'currdev' (with ZFS, this is set by the bootfs pool property) variable if it is not overridden by vfs.root.mountfrom --=20 Allan Jude --oIovhPnoVQVmm6SgU5xLvIvKc5cGgQ9Lj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJWtpg6AAoJEBmVNT4SmAt+XsUQAOAQrBKXFlckQBhGUPVcqSTE QLNJ5j3Tw/chawtWSuqxEJPTGVaAYTPAnOV8TM8VBaN+IJ2zTUPo2OKS7/MD/mgd JUwzPFbMDnRbfWpgRNlKxqtvP5oogqkhWofRil8jqZtc26K7WXzEfBbQB2vWZOhm feIri45rkQuoPg9UNBJjGCEMitK+Nmhoub8VjC7dCAsvTO59ZjBMKJRqEob2VyIk 5k4lpO1xrGR7MBoxXGmV3tTAmJXNnGvXbuRqr1Jx/coPkk6ZQHX1xXdLBebeBTwE CZ6aggjZEG/2Bu0o5tZ/SLck7qVzLZ1xNH9T+3GFIgte12C1Pgo15s9p2kaHBz+h Cz86gLt3CY5eE4Kb3dhiMnglurJlGczECW+Q3pP/TZrUVT/2dI3r8qTvuHna2/Vq Dx/mXFTKEHApAqs5+igfjtWflpflK6ZQJLF8hpVWm02ECrNsCjV7vBpupyDUc/O7 zmdCpQYjm2K0Ps01xRA4wtHKOw54QL/J239sbrvfIrlDb81cZjEV4khW5Ic+gM16 YU8kJeL15vh4GJhHVr+fO0FMLINIKyCSgf5J3jOJsKqXfZd89mnIzsoMW44UeFZX Jp1eChA+MJt44Z1x1CsQPJwIQA1dn/iIZCoNuqeS6YEAFyk527XD/QSanTXR0Ica Doesg99VpYhMsDZhCnRE =+yKv -----END PGP SIGNATURE----- --oIovhPnoVQVmm6SgU5xLvIvKc5cGgQ9Lj--