From owner-p4-projects@FreeBSD.ORG  Thu Feb  9 18:09:01 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E70C116A423; Thu,  9 Feb 2006 18:09:00 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C0E4216A420
	for <perforce@freebsd.org>; Thu,  9 Feb 2006 18:09:00 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 93DCE43D48
	for <perforce@freebsd.org>; Thu,  9 Feb 2006 18:09:00 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k19I90Qt025272
	for <perforce@freebsd.org>; Thu, 9 Feb 2006 18:09:00 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k19I90E1025269
	for perforce@freebsd.org; Thu, 9 Feb 2006 18:09:00 GMT
	(envelope-from jhb@freebsd.org)
Date: Thu, 9 Feb 2006 18:09:00 GMT
Message-Id: <200602091809.k19I90E1025269@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 91432 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Feb 2006 18:09:02 -0000

http://perforce.freebsd.org/chv.cgi?CH=91432

Change 91432 by jhb@jhb_slimer on 2006/02/09 18:08:03

	Use the single pfs_visible() call in pfs_getextattr() that des@
	prefers.

Affected files ...

.. //depot/projects/smpng/sys/fs/pseudofs/pseudofs_vnops.c#41 edit

Differences ...

==== //depot/projects/smpng/sys/fs/pseudofs/pseudofs_vnops.c#41 (text+ko) ====

@@ -287,15 +287,6 @@
 
 	PFS_TRACE((pn->pn_name));
 
-#if 0
-	/* Umm, no need to call this twice. */
-	if (!pfs_visible(curthread, pn, pvd->pvd_pid))
-		PFS_RETURN (ENOENT);
-#endif
-
-	if (pn->pn_getextattr == NULL)
-		PFS_RETURN (EOPNOTSUPP);
-
 	/*
 	 * This is necessary because either process' privileges may
 	 * have changed since the open() call.
@@ -303,6 +294,12 @@
 	if (!pfs_visible(curthread, pn, pvd->pvd_pid, &proc))
 		PFS_RETURN (EIO);
 
+	if (pn->pn_getextattr == NULL) {
+		if (proc != NULL)
+			PROC_UNLOCK(proc);
+		PFS_RETURN (EOPNOTSUPP);
+	}
+
 	if (proc != NULL) {
 		_PHOLD(proc);
 		PROC_UNLOCK(proc);