From owner-cvs-all Wed Jan 27 21:56:35 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA18137 for cvs-all-outgoing; Wed, 27 Jan 1999 21:56:35 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA18132; Wed, 27 Jan 1999 21:56:34 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.2/8.9.1) id VAA93512; Wed, 27 Jan 1999 21:56:31 -0800 (PST) (envelope-from dillon) Date: Wed, 27 Jan 1999 21:56:31 -0800 (PST) From: Matthew Dillon Message-Id: <199901280556.VAA93512@apollo.backplane.com> To: "Justin T. Gibbs" Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/eisa ahb.c References: <199901280332.UAA25969@pluto.plutotech.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk :> :> Modified files: :> sys/i386/eisa ahb.c :> Log: :> Fix parenthesization, but the code still looks wrong. :> :> Revision Changes Path :> 1.5 +7 -2 src/sys/i386/eisa/ahb.c : :There certainly was a bug there, but your commit made the driver :non-functional. Why not pass your concern on to the author/maintainer of :the driver instead of committing something that does not address the :problem? If I had missed your checkin mail, I would never have noticed the :bug especially after you cleared the compiler warning without really fixing :the problem. : :I've committed a proper fix. : :-- :Justin The discussion was moved to the scsi list, and I still had it dogeared but you are right - I probably should not have committed the parenthesization fix. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message