From nobody Fri Jun 10 22:23:53 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 507AA83CD99; Fri, 10 Jun 2022 22:23:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LKb8n1hPnz3n2c; Fri, 10 Jun 2022 22:23:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654899833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kPbtXcSENThFbPSoTsZb/F5oF3IV0hYk2RLGNy8vUQs=; b=o7b7bTTMUwqq7f2oClIs01mdYFien8q0yMBrN5M2uPJy94tDtVlbJpjW+d75iO7BoaCz+B 2qz1LxoWcySYj+h3SBvespdsr7B1UMsiGS87DRp4pL3oVTP/S08CT0w02e4c76YtJ3tn2j qbmePacQbbAnFufxjNlM7vihjRZqlzzbLcHMjoQpK6GbpTM2jTxPkqKGXgjXWpgAtVSG34 F7zx9WpcWYf81kOxpNOOYk7ohJlseNqSyEXB14qPSjEiG/UVABqSgfIGHmcgDwAGvVVlBD gbpfUV2+alMuVUy3zhFg7biGRzncBgf9+8hXt/GX510uVDY415xVB+3NwaJQxg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1AA9F2109B; Fri, 10 Jun 2022 22:23:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25AMNrMI026755; Fri, 10 Jun 2022 22:23:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25AMNrNo026754; Fri, 10 Jun 2022 22:23:53 GMT (envelope-from git) Date: Fri, 10 Jun 2022 22:23:53 GMT Message-Id: <202206102223.25AMNrNo026754@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: d40f62f89d6a - stable/12 - nfscl: Add a diagnostic printf() for a "should never happen" case List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: d40f62f89d6a5ab9fc9c1911c783beef9c80188d Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654899833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kPbtXcSENThFbPSoTsZb/F5oF3IV0hYk2RLGNy8vUQs=; b=UCmeE6yChdHSs8v1ln5sULrSs+8FpqhF/CVA01rpl0jGGC0BAYZ6/Zfbm1ZDzpsshgA5ef 5+4t+nDLebvWg5dqktyEWC/kWnjGdYDto114M8j++1Vz1VPVWDInE86FxARNgTSvZRMgmR Jns+cuE80P/1pprvUdmJpOctsTuwKZF9Rjy5qV55rwi51eZ4NBuAwP75xvEQCTETrKzGbb VOyTcC1i/CYmvkfzlGX4n1Fgi4blv8xwCw4v5sIb2or3PZvrX6/tjyCdz0lZYUN6/RcYN/ wl8n0uyWXOeEgv1VmpBrwlU53RJKEOrkacm3hXlnOj/xZPxkXMSHHvEqMwJqvA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654899833; a=rsa-sha256; cv=none; b=rJs5KdJblO3mJlg8QnX3C6K6PuPbBanEmhmLdLf+jxoejRbQ1jvngR/cGzP1oE/CajzwLl sV4XDnixX3nFI/lW+kn1HYsFaxFaUArBdxP9it3ohvLABJh1zzO4f4CM8Grw+VhRx3KDw+ O+fHNMQBIyDkRFpcIntmn/Ei6kEVaml6jK3JeUoohWYN9zruYdFdoVKOTlo5WomA8r2GT/ a9vQH1qYVpAt9bfGU41wiOkAKLfuIDE7etfSRL6PPC1BaR2AvII0mj7BDflH/dS+40W3H0 ZGPJTriaOniS3JbFqUj2yQPSqOfptBeoFRhYBXsJX30iPZi0O01AbEfkqeYKxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=d40f62f89d6a5ab9fc9c1911c783beef9c80188d commit d40f62f89d6a5ab9fc9c1911c783beef9c80188d Author: Rick Macklem AuthorDate: 2022-05-27 21:32:46 +0000 Commit: Rick Macklem CommitDate: 2022-06-10 22:22:57 +0000 nfscl: Add a diagnostic printf() for a "should never happen" case When a NFSv4.1/4.2 session to the NFS server (not a pNFS DS) is replaced, the old session should always be marked defunct by nfsess_defunct being set non-zero. However, the hang reported by the PR suggests that this might be the case. This patch adds a printf() to indicate this has somehow happened. PR: 260011 (cherry picked from commit a7bb120f8b8735bc4c417b3c8fc2308c3d2964aa) --- sys/fs/nfsclient/nfs_clrpcops.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/fs/nfsclient/nfs_clrpcops.c b/sys/fs/nfsclient/nfs_clrpcops.c index 01b8eda2e441..3e081fa750db 100644 --- a/sys/fs/nfsclient/nfs_clrpcops.c +++ b/sys/fs/nfsclient/nfs_clrpcops.c @@ -973,8 +973,12 @@ nfsrpc_setclient(struct nfsmount *nmp, struct nfsclclient *clp, int reclaim, * in-progress RPCs. */ tsep = NULL; - if (TAILQ_FIRST(&nmp->nm_sess) != NULL) + if (TAILQ_FIRST(&nmp->nm_sess) != NULL) { tsep = NFSMNT_MDSSESSION(nmp); + if (tsep->nfsess_defunct == 0) + printf("nfsrpc_setclient: " + "nfsess_defunct not set\n"); + } TAILQ_INSERT_HEAD(&nmp->nm_sess, dsp, nfsclds_list); /*