From owner-freebsd-stable@FreeBSD.ORG  Sat Jun  4 18:58:41 2005
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: freebsd-stable@freebsd.org
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E945116A41C
	for <freebsd-stable@freebsd.org>; Sat,  4 Jun 2005 18:58:41 +0000 (GMT)
	(envelope-from torfinn.ingolfsen@broadpark.no)
Received: from osl1smout1.broadpark.no (osl1smout1.broadpark.no [80.202.4.58])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8ABEE43D49
	for <freebsd-stable@freebsd.org>; Sat,  4 Jun 2005 18:58:41 +0000 (GMT)
	(envelope-from torfinn.ingolfsen@broadpark.no)
Received: from osl1sminn1.broadpark.no ([80.202.4.59])
	by osl1smout1.broadpark.no
	(Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004))
	with ESMTP id <0IHK004ODQ1U1030@osl1smout1.broadpark.no> for
	freebsd-stable@freebsd.org; Sat, 04 Jun 2005 20:58:42 +0200 (CEST)
Received: from kg-work.kg4.no ([80.203.21.150]) by osl1sminn1.broadpark.no
	(Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004))
	with SMTP id <0IHK00B9RQ7XKW20@osl1sminn1.broadpark.no> for
	freebsd-stable@freebsd.org; Sat, 04 Jun 2005 21:02:22 +0200 (CEST)
Date: Sat, 04 Jun 2005 20:58:37 +0200
From: Torfinn Ingolfsen <torfinn.ingolfsen@broadpark.no>
X-Face: "t9w2,-X@O^I`jVW\sonI3.,36KBLZE*AL[y9lL[PyFD*r_S:dIL9c[8Y>V42R0"!"yb_zN,f#%.[PYYNq;
	m"_0v;
	~rUM2Yy!zmkh)3&U|u!=<N>T(zyv,MHJv"nDH>OJ`t(@mil461d_B'Uo|'nMwlKe0Mv=kvV?Nh@>Hb<3s_z2jYgZhPb@?Wi^x1a~Hplz1.zH
In-reply-to: <20050604202735.3198a818.torfinn.ingolfsen@broadpark.no>
To: freebsd-stable@freebsd.org
Message-id: <20050604205837.12afb237.torfinn.ingolfsen@broadpark.no>
MIME-version: 1.0
X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-portbld-freebsd5.3)
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
References: <429CA163.70608@icyb.net.ua>
	<20050604202735.3198a818.torfinn.ingolfsen@broadpark.no>
Subject: Re: xffm - xfsamba4 broken in 5-stable?
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Jun 2005 18:58:42 -0000

On Sat, 04 Jun 2005 20:27:35 +0200
Torfinn Ingolfsen <torfinn.ingolfsen@broadpark.no> wrote:

> Ok, so you just removed that line from tubo.c?

Reading the line in context shows that this might indeed be the correct
fix, here is the context:
#ifdef  __FreeBSD__
    /* This apparently does the bug workaround for wait failure
     * on FreeBSD 5.1: */
     if (kill(PID,SIGCONT) == 0) return TRUE;
#endif

Perhaps this should be removed, or at least fixed so that it only is
needed on FreeBSD 5.1.

> I wonder if this is the correct way to fix it, but anyway, I'm going
> to try it.

And it worked. I did a 'make extract' in the xfce4-fm port directory,
removed the offending line 'if (kill(PID...', and did a 'make deinstall'
followed by a 'make reinstall'.
Now xfsamba4 works like it did before.
-- 
Regards, 
Torfinn Ingolfsen,
Norway