From owner-freebsd-arch@FreeBSD.ORG Fri Feb 6 03:20:11 2015 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AA6663AA for ; Fri, 6 Feb 2015 03:20:11 +0000 (UTC) Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7463A95A for ; Fri, 6 Feb 2015 03:20:11 +0000 (UTC) Received: by mail-ig0-f179.google.com with SMTP id l13so4789516iga.0 for ; Thu, 05 Feb 2015 19:20:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=nmIvXqfTEJCtLRXUneqiTEaEpBvRlKhg2Wxd56Mfd6o=; b=OGFf1ZCvk0N0skLli5DmXCHq0DlMJK08hP8QEhuhwaQAu9QYKUhN36Nm25muzwxhTT V55gJJlcUcZFFulwCV96oP2CTnH4BJbcPgBPDe8djPwu0RsIukNZvl5YTP9fUNAoEEl7 OinrWvJpf43ciWDbOUx8ofCSgK0+lM5Yl13tpf4MOnOOO2Dbfr26c59S0g1i/ZQevpdY U0MH3ph9BYTckqcTc5OdQ5w6D27Q5WVWlmjpln3Rdg3mPJhcF9RapSbmrTeqX7c3/e7J 9WzTNTdCrB7vuN0AuN+LrqpiODMSjCEvL91/iaEN4emWg/ljPvdiBc/apXI5cN7X8J4b MKNA== X-Gm-Message-State: ALoCoQnLrz/0xR8O6VjgyrHEOaZ3GdTRdyq7ELcMdGyi5ey6PEHyRhYISpcx/Y7pC53SNz4i+u8I X-Received: by 10.51.17.1 with SMTP id ga1mr128065igd.33.1423192810322; Thu, 05 Feb 2015 19:20:10 -0800 (PST) Received: from netflix-mac-wired.bsdimp.com ([50.253.99.174]) by mx.google.com with ESMTPSA id 3sm629314iof.8.2015.02.05.19.20.09 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Feb 2015 19:20:09 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Better way to do conditional inclusion in make From: Warner Losh In-Reply-To: Date: Thu, 5 Feb 2015 20:20:09 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <105BE327-D1C3-492D-866C-F3F3FB48D991@bsdimp.com> References: <39C20BA1-E6B1-4DAE-95BB-8011A0A64D54@bsdimp.com> <54D40DC4.9070907@freebsd.org> To: NGie Cooper X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 03:20:11 -0000 > On Feb 5, 2015, at 6:06 PM, NGie Cooper wrote: >=20 > On Thu, Feb 5, 2015 at 4:41 PM, Julian Elischer = wrote: >=20 > ... >=20 >> how does it cope with the case where a single file is dependent on = either of >> two options. >> (we have this in our tree.. not sure if it occurs in the FreeBSD = tree.) >> file could occur in both lists or twice in one list.. >=20 > This is a good, valid point. I think that Warner's proposal will fix > the simple case (using one knob), but not the more complex case. This isn=E2=80=99t that valid a point. It=E2=80=99s a trivial annoyance. = When this construct can=E2=80=99t cope (like for things that deal with arch dependent = stuff), you fall back to old-school ifs. > What concerns me about the short description of the implementation, > (and something that I'm going to add to the phabricator review) is > that this will: >=20 > 1. Break using FILESGROUPS How? > 2. Requires creating snippets for dealing with magic in bsd.*.mk (I > wouldn't want this magic going into the general purpose snippets > because it would probably break backwards compatibility). Explain. Warner=