From owner-freebsd-stable@FreeBSD.ORG  Mon Jan  4 01:59:16 2010
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4D19B1065676
	for <freebsd-stable@freebsd.org>; Mon,  4 Jan 2010 01:59:16 +0000 (UTC)
	(envelope-from dimitry@andric.com)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 147FF8FC18
	for <freebsd-stable@freebsd.org>; Mon,  4 Jan 2010 01:59:16 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:e0a6:573d:e5c6:5f8a] (unknown
	[IPv6:2001:7b8:3a7:0:e0a6:573d:e5c6:5f8a])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id 39D465C43;
	Mon,  4 Jan 2010 02:59:15 +0100 (CET)
Message-ID: <4B414B76.2060900@andric.com>
Date: Mon, 04 Jan 2010 02:59:18 +0100
From: Dimitry Andric <dimitry@andric.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US;
	rv:1.9.2b6pre) Gecko/20100103 Lanikai/3.1a1pre
MIME-Version: 1.0
To: Jilles Tjoelker <jilles@stack.nl>
References: <86095ec11001021301i25e91191kdcc2a1673795dce7@mail.gmail.com>
	<20100103140303.GA1899@stack.nl>
In-Reply-To: <20100103140303.GA1899@stack.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "E. O." <enginbsd@gmail.com>, freebsd-stable@freebsd.org
Subject: Re: locale-related build problems
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2010 01:59:16 -0000

On 2010-01-03 15:03, Jilles Tjoelker wrote:
> This should be fixed by adding LC_ALL=C somewhere in the build process,
> possibly only for these awk commands.

Here is a quite minimal diff to do so, at least for the buildkernel
part.

In any case, it looks like awk is used quite a lot in other places
during buildworld; some of these invocations already use LC_ALL=C, most
of them do not.  There are even invocations of sh using LC_ALL=C. :)

Instead of peppering the whole tree with LC_ALL=C insertions, would it
make sense to simply set LC_ALL=C globally during building world and
kernel?  Or are there parts that actually use locales during the build?


Index: sys/conf/kern.pre.mk
===================================================================
--- sys/conf/kern.pre.mk	(revision 201193)
+++ sys/conf/kern.pre.mk	(working copy)
@@ -14,7 +14,7 @@
  
  M=	${MACHINE_ARCH}
  
-AWK?=		awk
+AWK?=		LC_ALL=C awk
  LINT?=		lint
  NM?=		nm
  OBJCOPY?=	objcopy
Index: sys/conf/kmod.mk
===================================================================
--- sys/conf/kmod.mk	(revision 201193)
+++ sys/conf/kmod.mk	(working copy)
@@ -60,7 +60,7 @@
  #		Unload a module.
  #
  
-AWK?=		awk
+AWK?=		LC_ALL=C awk
  KMODLOAD?=	/sbin/kldload
  KMODUNLOAD?=	/sbin/kldunload
  OBJCOPY?=	objcopy