From owner-freebsd-arch@FreeBSD.ORG  Tue Aug 31 20:28:48 2004
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4235416A4CE
	for <freebsd-arch@freebsd.org>; Tue, 31 Aug 2004 20:28:48 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E5F1943D1D
	for <freebsd-arch@freebsd.org>; Tue, 31 Aug 2004 20:28:47 +0000 (GMT)
	(envelope-from scottl@freebsd.org)
Received: from [192.168.0.12] (g4.samsco.home [192.168.0.12])
	(authenticated bits=0)
	by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i7VKSQHZ072709;
	Tue, 31 Aug 2004 14:28:26 -0600 (MDT)
	(envelope-from scottl@freebsd.org)
Message-ID: <4134DF35.7070605@freebsd.org>
Date: Tue, 31 Aug 2004 14:27:33 -0600
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7) Gecko/20040514
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Sam <sah@softcardsystems.com>
References: <Pine.LNX.4.60.0408311611550.7530@athena>
In-Reply-To: <Pine.LNX.4.60.0408311611550.7530@athena>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org
cc: freebsd-arch@freebsd.org
Subject: Re: option directive and turning on AOE
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Aug 2004 20:28:48 -0000

Sam wrote:

> Hello,
> 
> I've added code to if_ethersubr.c:/ether_demux/
> to queue up AoE frames as they appear.  I followed
> suit with other protocols and included my addition
> inside of an #ifdef AOE.  Where do I turn this on?
> I thought perhaps just adding an 'option AOE' to
> the config would do it, but it doesn't -- so clearly
> I don't understand how the option directive works.
> The config man page doesn't talk about option/device
> directives ...
> 
> I'm still looking, but a clue would be well received.
> 
> Cheers,
> 
> Sam
> 

Did you modify /sys/conf/options to tell it about your
AOE option?  If so, then you should have specified the name
of a header file that the option would be #define'd into.
Include that header file in if_ethersubr.c and you should
have no problems.

Incidentally, this might be an area when netgraph would be
useful.  Instead of having an AoE specific hook in the
stack, you could have an AoE netgraph module that uses the
existing netgraph hooks.  It's just an idea, though.

Scott