From nobody Thu Mar 26 01:13:34 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fh5Pw4QzSz6X3xP for ; Thu, 26 Mar 2026 01:13:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fh5Pw2F2yz3JKZ for ; Thu, 26 Mar 2026 01:13:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774487620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U7xC+d9JOhAKcZJ4JDrp6hhAM+2SmPnj5J8Nx8Sw6Nw=; b=f/bWVYZyZ32RhBTXa4vmZiTJ/sD+yxlaCdPrF5kj3kqbPFshCCNYEE9QwhVBmsNNCtyyyv 8tSz6JRxTmp0V0BgtIWiXLFFQklDt3ihI7iiU87BUEdEdpGhMYQ9V1RA+CnlGyDZawRHnJ 1JwZ0mVK8F98PhItjpmTd3/wMdreFmrLNMaTgq1/NYIObmWNnnAEg4+R4aSyWhPwM2nFgh e3U++lgyZ+qwbQb1eo4OFKxMa+KYqm9lfuUlUwmHuM10clAXXcH9AgZLEzIRgz7dcg/PA2 1irSk1R9/wCggcaSqxNLwgSkHnng49pIOTMKAOdg28+fmjXCGCwanY5Ce17SnA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774487620; a=rsa-sha256; cv=none; b=MgXG5njA+IQeedITFeKtnkCc1eXyhsgUulmZP/ib6oESj/BasOmp5zwgnoxDcyYWr+JsG3 SOHg1KQNtcvHOK2SATYlM04oax8FCSRWoTlsusY4Ooau3ZdWva3V2NOIqOfdJ2Xfnkui8L oFPRb2ZdGoFTrKuu3c200/kL+I9usE4XFhW5grFyTIfknwmw8EHO6qdDNFCKw062VtIlgV GZi/Q9LiUhfGs1C+ByAvOMNZhkCTGG3jKbkFXS4DZCinrAkR6kNAHRRK2olU2pZBuZ64O4 M8YO4CLbJmvj8np9VgkIjyEBA4VvHWg9s3Rr1M7KFE2HLvsldPxN0bQyQqnWyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774487620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U7xC+d9JOhAKcZJ4JDrp6hhAM+2SmPnj5J8Nx8Sw6Nw=; b=yFlzl8Fb4dcPGrd0DzTPueTd7z9tDWqYSa2J5VqoWiZ5mCA0zRlmCr89xWDJXGrv3serrr FyBvzS3SNsoOoTRVM7F92ZI/vXpoW2NwrLBEV3U2RspWzy6Fc+2puOP6oJ0r1cZ7X9ihYx dKTI+GjZEqJ9PA75kDbOwPmghbhKuVO7sG8wuQbF+/ROftmlXZoM0jrsQi04ObNz5o6YHX asYA8W1T8iKdIHB/o70tWqD45lakkCm1uQFo/CSlp0UlOE/T8X/WWQ2JeKpQL2GRXY+HNh 0sszpBVBY3Rh27/gV1TU+gpza0CzXg4VsQ9qAlTnwwvP79aEfp34jpmFwy+3Jg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fh5Pw1nXRzVCb for ; Thu, 26 Mar 2026 01:13:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19308 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Mar 2026 01:13:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Michael Tuexen From: Gordon Tetlow Subject: git: 6b2d6ccad255 - main - tcp: plug an mbuf leak List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6b2d6ccad2552e46a5c9c3ba70b2d0ed27c70ca8 Auto-Submitted: auto-generated Date: Thu, 26 Mar 2026 01:13:34 +0000 Message-Id: <69c4883e.19308.14bd579e@gitrepo.freebsd.org> The branch main has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=6b2d6ccad2552e46a5c9c3ba70b2d0ed27c70ca8 commit 6b2d6ccad2552e46a5c9c3ba70b2d0ed27c70ca8 Author: Michael Tuexen AuthorDate: 2026-03-25 05:53:56 +0000 Commit: Gordon Tetlow CommitDate: 2026-03-26 01:11:54 +0000 tcp: plug an mbuf leak When a challenge ACK should be sent via tcp_send_challenge_ack(), but the rate limiter suppresses the sending, free the mbuf chain. The caller of tcp_send_challenge_ack() expects this similar to the callers of tcp_respond(). Approved by: so Security: FreeBSD-SA-26:06.tcp Security: CVE-2026-4247 Reviewed by: lstewart Tested by: lstewart Sponsored by: Netflix, Inc. --- sys/netinet/tcp_subr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index 8aa8a7b7fefc..b6bb0221e872 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -2216,6 +2216,8 @@ tcp_send_challenge_ack(struct tcpcb *tp, struct tcphdr *th, struct mbuf *m) tcp_respond(tp, mtod(m, void *), th, m, tp->rcv_nxt, tp->snd_nxt, TH_ACK); tp->last_ack_sent = tp->rcv_nxt; + } else { + m_freem(m); } }