From owner-svn-ports-all@freebsd.org Tue Dec 26 07:16:27 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52487EA66D3; Tue, 26 Dec 2017 07:16:27 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 33A23682C5; Tue, 26 Dec 2017 07:16:27 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 5895C1C5CB; Tue, 26 Dec 2017 07:16:26 +0000 (UTC) Date: Tue, 26 Dec 2017 07:16:26 +0000 From: Alexey Dokuchaev To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457245 - in head/net-p2p: bitcoin litecoin Message-ID: <20171226071626.GC27490@FreeBSD.org> References: <201712251807.vBPI7mAd012038@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201712251807.vBPI7mAd012038@repo.freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2017 07:16:27 -0000 On Mon, Dec 25, 2017 at 06:07:48PM +0000, Jan Beich wrote: > New Revision: 457245 > URL: https://svnweb.freebsd.org/changeset/ports/457245 > > Log: > net-p2p/bitcoin: unbreak with boost 1.66 > > PR: 224129 224132 > Obtained from: upstream (Bitcoin 0.16.0) > Approved by: portmgr blanket > > Modified: head/net-p2p/bitcoin/Makefile > ... > @@ -7,6 +7,9 @@ DISTVERSIONPREFIX= v > PORTREVISION?= 2 > CATEGORIES= net-p2p finance > > +PATCH_SITES= https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/ > +PATCHFILES= 1ec0c0a01c31.patch:-p1 ... > > Modified: head/net-p2p/bitcoin/distinfo > ... > +SIZE (1ec0c0a01c31.patch) = 3535 I'd like to bring to your attention (again) that this approach of fetching external patches is fragile and already had broken things in the past. Putting 3535-byte patch file in ${FILESDIR} is perfectly fine for its size (and EXTRA_PATCHES also supports :-p1). ./danfe