From owner-freebsd-hackers@FreeBSD.ORG Mon Oct 6 07:28:53 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C389106569A; Mon, 6 Oct 2008 07:28:53 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 02B368FC0A; Mon, 6 Oct 2008 07:28:52 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m967QKhD036631; Mon, 6 Oct 2008 01:26:20 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 06 Oct 2008 01:26:19 -0600 (MDT) Message-Id: <20081006.012619.78741615.imp@bsdimp.com> To: bagavathykumar.m@hcl.in From: Warner Losh In-Reply-To: <68C9F31EF19DB6448F515EF294028FDEE9A624@chn-hclt-evs05.HCLT.CORP.HCL.IN> References: <68C9F31EF19DB6448F515EF 294028FDEE9A4A5@chn-hclt-evs05.HCLT.CORP.HCL.IN> <20081006.005657.71122961.imp@bsdimp.com> <68C9F31EF19DB6448F515EF294028FDEE9A624@chn-hclt-evs05.HCLT.CORP.HCL.IN> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@freebsd.org Subject: Re: i386/127710: My driver PCI probe is not called formycorrespondingdevice ID and Vendor ID X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2008 07:28:53 -0000 From: "Bagavathy Kumar Mahendran " Subject: RE: i386/127710: My driver PCI probe is not called formycorrespondingdevice ID and Vendor ID Date: Mon, 6 Oct 2008 12:36:44 +0530 > Dear Warner, > > My probe is getting called for the parent bridge devices > .but > Not for my pci Card. I have tested this by printing the Device ID and > Vendor ID of the corresponding device_t in my probe. > > You are trying to say even cbb probes for my device and return > BUS_PROBE_DEFAULT still my probe function will be called. Just clarify > it. > But my testing seems that my probe is not called for my pci device Can you send me the DRIVER_MODULE line in your driver? Warner > Bagavathy kumar .M > > > -----Original Message----- > From: Warner Losh [mailto:imp@bsdimp.com] > Sent: Monday, October 06, 2008 12:27 PM > To: Bagavathy Kumar Mahendran > Cc: jhb@freebsd.org; freebsd-hackers@freebsd.org > Subject: Re: i386/127710: My driver PCI probe is not called > formycorrespondingdevice ID and Vendor ID > > > Thanks for your support. my probe is getting called for > all > > the bridges not for my pci device. so please provide the fix . > > > > OR > > Is any other way available for making my driver to override the probe > of > > cbb driver for my corresponding device (With out changing cbb driver). > > If your probe returns a higher number that's negative, it will. > Unless cbb is returning 0, your probe routine will get called. Make > sure it isn't. Code inspection suggests that it isn't. > > Warner > > > > > With regards, > > Bagavathy kumar .M > > > > -----Original Message----- > > From: M. Warner Losh [mailto:imp@bsdimp.com] > > Sent: Friday, October 03, 2008 11:03 AM > > To: Bagavathy Kumar Mahendran > > Cc: jhb@freebsd.org; freebsd-hackers@freebsd.org > > Subject: Re: i386/127710: My driver PCI probe is not called for > > mycorrespondingdevice ID and Vendor ID > > > > In message: > > > <68C9F31EF19DB6448F515EF294028FDEE99BCE@chn-hclt-evs05.HCLT.CORP.HCL.IN> > > "Bagavathy Kumar Mahendran " > > writes: > > : > > : Dear Baldwin, > > : Thanks for your support .but my pci probe function is > > not > > : getting called for my device id and vendor id. Because pccbb driver > > : already sets the device_set_desc as PCI-CardBus Bridge. So is there > > any > > : other option for me to make my_pciprobe function to be called for my > > : corresponding device id and vendor id. > > > > That's not why your probe isn't called. Setting a description is > > standard behavior for the probe routine. Are you sure that the device > > probe routine is getting called at all for any device? Have you tried > > just leaving cbb out of the kernel? I recently fixed the original > > problem in cbb (the fact it doesn't check the bridge type too), maybe > > you could try to pick up that fix as well? > > > > Warner > > > > > > : Thanks, > > : > > : Regards, > > : Bagavathy kumar .M > > : > > : > > : > > : -----Original Message----- > > : From: John Baldwin [mailto:jhb@freebsd.org] > > : Sent: Wednesday, October 01, 2008 8:57 PM > > : To: freebsd-hackers@freebsd.org > > : Cc: Bagavathy Kumar Mahendran ; Warner Losh > > : Subject: Re: FW: i386/127710: My driver PCI probe is not called for > my > > : correspondingdevice ID and Vendor ID > > : > > : On Wednesday 01 October 2008 08:50:15 am Bagavathy Kumar Mahendran > > : wrote: > > : > > > : > Dear All, > > : > Iam writing a new driver for a SAS/SATA Controller > > having > > : a > > : > Class ID -0x01 > > : > Sub Class - 0x07 > > : > Programming Interface - 0x00 > > : > > > : > Hence instead of my probe function the Static build Card Bus > Driver > > : cbb > > : > is attaching just by simply checking sub class 0x07 and > programming > > : > interface 0x00.hence my probe gets failed. Kindly help me in > > resolving > > : > this .what I thought is to add the card bus driver a checking of > > CLASS > > : > ID in its pci probe function. > > : > > : The pccbb driver returns BUS_PROBE_DEFAULT (it should probably > return > > : GENERIC > > : in the case where it matches only on class codes). Your driver just > > : needs to > > : return a numerically higher value (but still < 0) to claim the > device. > > : You > > : can probably use BUS_PROBE_VENDOR or BUS_PROBE_DEFAULT + 1. > > : > > : -- > > : John Baldwin > > : > > : DISCLAIMER: > > : > > > ------------------------------------------------------------------------ > > ----------------------------------------------- > > : > > : The contents of this e-mail and any attachment(s) are confidential > and > > intended for the named recipient(s) only. > > : It shall not attach any liability on the originator or HCL or its > > affiliates. Any views or opinions presented in > > : this email are solely those of the author and may not necessarily > > reflect the opinions of HCL or its affiliates. > > : Any form of reproduction, dissemination, copying, disclosure, > > modification, distribution and / or publication of > > : this message without the prior written consent of the author of this > > e-mail is strictly prohibited. If you have > > : received this email in error please delete it and notify the sender > > immediately. Before opening any mail and > > : attachments please check them for viruses and defect. > > : > > : > > > ------------------------------------------------------------------------ > > ----------------------------------------------- > > : > > : > > > > > >