From owner-svn-ports-all@freebsd.org Mon Jan 22 21:09:26 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1022FED5F27; Mon, 22 Jan 2018 21:09:26 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from hz.grosbein.net (hz.grosbein.net [78.47.246.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9217C6F014; Mon, 22 Jan 2018 21:09:25 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w0ML9H3G015380 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Jan 2018 22:09:18 +0100 (CET) (envelope-from eugen@freebsd.org) X-Envelope-From: eugen@freebsd.org X-Envelope-To: mat@FreeBSD.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w0ML9Dnl010573 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 23 Jan 2018 04:09:14 +0700 (+07) (envelope-from eugen@freebsd.org) Subject: Re: svn commit: r459676 - in head/sysutils/zfsnap: . files To: Mathieu Arnold References: <201801221705.w0MH5n8N044357@repo.freebsd.org> <20180122172614.ptlibdvjq42myqzp@aragorn.in.absolight.net> <5A662E1F.6010408@freebsd.org> <20180122192531.7xs4zndt6wrh3nbq@atuin.in.mat.cc> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Eugene Grosbein Message-ID: <5A6652F6.4000406@freebsd.org> Date: Tue, 23 Jan 2018 04:09:10 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20180122192531.7xs4zndt6wrh3nbq@atuin.in.mat.cc> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,RDNS_NONE, SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.1 X-Spam-Report: * 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 1.9 RDNS_NONE Delivered to internal network by a host with no rDNS X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 21:09:26 -0000 23.01.2018 2:25, Mathieu Arnold wrote: > On Mon, Jan 22, 2018 at 06:31:59PM +0000, Eugene Grosbein wrote: >> 23.01.2018 0:26, Mathieu Arnold wrote: >> >>> On Mon, Jan 22, 2018 at 05:05:49PM +0000, Eugene Grosbein wrote: >>>> Move creation of files from "do-patch" to "post-extract" target, >>>> so that patches from files/ directory get applied. >>>> >>>> -do-patch: >>>> +post-extract: >>> >>> I am sure you meant to use post-extract here. >> >> And I did. What is a problem here? > > Sorry, meant post-patch here. "post-patch" means we will not be able conditionally patch generated files with extra-patches, for example. As we could not apply simple patch before this change due to abuse of "do-patch". So, "post-extract" is intentional.