From owner-freebsd-current@FreeBSD.ORG  Wed Jul 23 10:14:49 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AD08637B401
	for <freebsd-current@FreeBSD.ORG>;
	Wed, 23 Jul 2003 10:14:49 -0700 (PDT)
Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net
	[66.199.86.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 046CC43F93
	for <freebsd-current@FreeBSD.ORG>;
	Wed, 23 Jul 2003 10:14:49 -0700 (PDT)	(envelope-from das@FreeBSD.ORG)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6NHEkhC014722;
	Wed, 23 Jul 2003 10:14:46 -0700 (PDT)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6NHEjE6014721;
	Wed, 23 Jul 2003 10:14:45 -0700 (PDT)
	(envelope-from das@FreeBSD.ORG)
Date: Wed, 23 Jul 2003 10:14:45 -0700
From: David Schultz <das@FreeBSD.ORG>
To: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
Message-ID: <20030723171445.GB14408@HAL9000.homeunix.com>
Mail-Followup-To: Divacky Roman <xdivac02@stud.fit.vutbr.cz>,
	freebsd-current@freebsd.org
References: <20030720130221.GA39671@stud.fit.vutbr.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030720130221.GA39671@stud.fit.vutbr.cz>
cc: freebsd-current@FreeBSD.ORG
Subject: Re: possible unionfs bug
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jul 2003 17:14:50 -0000

On Sun, Jul 20, 2003, Divacky Roman wrote:
> Hi,
> 
> I might be wrong but this:
> 
>         free(mp->mnt_data, M_UNIONFSMNT);       /* XXX */
> 	mp->mnt_data = 0;
> 	
> seems to me wrong.... and might cause crashes etc.
> am I correct or wrong?
> 
> its from union_vfsops.c:384

What's wrong with it?  It's just freeing the memory it allocated
earlier.  FFS does the same thing.