From owner-freebsd-x11@FreeBSD.ORG Fri Mar 7 13:45:09 2014 Return-Path: Delivered-To: x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2D8661BD; Fri, 7 Mar 2014 13:45:09 +0000 (UTC) Received: from mailrelay012.isp.belgacom.be (mailrelay012.isp.belgacom.be [195.238.6.179]) by mx1.freebsd.org (Postfix) with ESMTP id 6A28B100; Fri, 7 Mar 2014 13:45:08 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlUGAN7MGVNR8mw2/2dsb2JhbABagwaBBr4ngwqBEhd0giUBAQEEOhwjEAsOCgklDyoeBogQAc9mF45bB4Q4AQOYQpIsgy48 Received: from 54.108-242-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.242.108.54]) by relay.skynet.be with ESMTP; 07 Mar 2014 14:45:01 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s27Dixhe014591; Fri, 7 Mar 2014 14:45:00 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Fri, 7 Mar 2014 14:44:58 +0100 From: Tijl Coosemans To: Alexey Dokuchaev Subject: Re: svn commit: r342587 - head/x11/pixman Message-ID: <20140307144458.6634ca47@kalimero.tijl.coosemans.org> In-Reply-To: <20140304170740.GA82945@FreeBSD.org> References: <201402041839.s14IdgAF097754@svn.freebsd.org> <20140204210959.044bc79a@kalimero.tijl.coosemans.org> <20140205121525.GB24764@FreeBSD.org> <20140304170740.GA82945@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Koop Mast , x11@FreeBSD.org X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2014 13:45:09 -0000 On Tue, 4 Mar 2014 17:07:40 +0000 Alexey Dokuchaev wrote: > On Wed, Feb 05, 2014 at 12:15:25PM +0000, Alexey Dokuchaev wrote: >> On Tue, Feb 04, 2014 at 09:09:59PM +0100, Tijl Coosemans wrote: >>> The is a bit strange because if you turn off SIMD you still get MMX and >>> SSE2 support if your cpu supports it. It should be something like this: >>> >>> .if ! ${PORT_OPTIONS:MSIMD} >>> CONFIGURE_ARGS= --disable-vmx --disable-arm-simd --disable-mmx \ >>> --disable-sse2 >>> .endif >>> >>> But then you're still missing --disable-ssse3 and a number of ARM and >>> MIPS SIMD options (reported by ./configure --help). >>> >>> I think it's best to just remove this whole block together with the >>> SIMD option because pixman tests at runtime what features the cpu >>> supports so in my opinion there's no reason to disable SIMD support. >> >> +1. I've always had to read inside the Makefile to understand what does >> this option do; it's very confusing up-front. Please remove it and/or >> hide the logic behind the trunk, so it DTRT without annoying users with >> cryptic dialogs. > > Do we have any consensus on this one now? Can we just remove the whole > SIMD logic from the Makefile? If nobody can come up with a reason to keep it, I'd say remove it.