From owner-svn-src-head@freebsd.org Wed May 24 16:26:22 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 48DA6D7C906; Wed, 24 May 2017 16:26:22 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0AB061437; Wed, 24 May 2017 16:26:22 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-oi0-x22e.google.com with SMTP id b204so248413756oii.1; Wed, 24 May 2017 09:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1mKs5uCw24aKza8ugHIhUmZZwN7AIdvnQJLEDXXXnvo=; b=IiqPjM7ezLyp6K0yCA1w0fIz5im/Mj5scxukPBnf+QQhcb+zinCmCL2KbrzTgxef6M 4C79V6FVRgOyqrZErBcySbwUWTja/LvyqaubwtAHFe8kFjYidfSuX/1eEm+qYNR4P9UO 6dfMh3HPJ03+E8rBqI/h6dcqXjgQGxrX61MGGxjitcnaKjUZa0KQdX/yM3UwPgs+MAul 3UhpUg6eiooDz5lXjNvxOrJfBwa3lA5PTV5WPinptjLyVb9NQlqsED5sHW/KYed40V1O dZmjev68PSyJKDihe6sRO9qYhc4EA/wucFqCKyOmSfPpMn9+TUJ/IRXlEt7fOorzwJ9L qFng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1mKs5uCw24aKza8ugHIhUmZZwN7AIdvnQJLEDXXXnvo=; b=MdXJiKZLhhHwAq5z/lhro2iptK/BajdvhBe29ikvTL5G1qgPiZ6U/0r2MH7CEGN5cA QfaXZ2gKIVkxnrOEkYVS/UqjD38ZLtqA3Q+PQvpq8bVFJ1vscH96/WcCrGWbqCqa/7Tn jBvBpBwyEkHq0d359+OkizlLxNyC7jwzExGUFJybpSTL7W7IqOLVjUVR7qWAc8ymIrpV 3XQ3DLALDLcOe/Ur3eutnT361LxmvcZ9FBPpr5aW9ANgmVGuH366E0+koRd4oO2S3Dd4 1LdE0kXEAaUH1WWy/bpHHu3NydXDViEZreq6lCZgMvIbBqoroo9A2aARS7B/D8h/SwQR o03w== X-Gm-Message-State: AODbwcAjO74HnN9zsooHNi6fWI+BLrbQUWiE7zxoPE3qn4tjZBP1de2j 3li6hqMk09um9MknOUEpUvUi63s7SHjc X-Received: by 10.202.4.144 with SMTP id 138mr15320887oie.105.1495643181154; Wed, 24 May 2017 09:26:21 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.202.219.197 with HTTP; Wed, 24 May 2017 09:26:00 -0700 (PDT) In-Reply-To: References: <201705230929.v4N9T5g1028124@repo.freebsd.org> From: Ed Maste Date: Wed, 24 May 2017 12:26:00 -0400 X-Google-Sender-Auth: wfOZ8K6n1f_5E8UVVZbotk7xUlE Message-ID: Subject: Re: svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libmi... To: Pedro Giffuni Cc: Konstantin Belousov , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 16:26:22 -0000 On 24 May 2017 at 10:53, Pedro Giffuni wrote: > > There is now a bunch of coverity issues (OVERFLOW_BEFORE_WIDEN mostly) > tied to ino64_t. At least the following CIDs are related: On a quick look the OVERFLOW_BEFORE_WIDEN issues are false positives in practice: for correct operation the product must fit within 32 bits, because inodes were previously 32 bits. However, it does seem unusual to perform a multiplication with types that could overflow 32 bits, and then store the result in a 64-bit variable. So it seems that a code change to eliminate the warning is likely reasonable.