From owner-freebsd-fs@FreeBSD.ORG  Fri May 15 12:39:21 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D3061065674;
	Fri, 15 May 2009 12:39:21 +0000 (UTC) (envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 2D5C58FC12;
	Fri, 15 May 2009 12:39:19 +0000 (UTC) (envelope-from avg@icyb.net.ua)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA07887;
	Fri, 15 May 2009 15:39:18 +0300 (EEST)
	(envelope-from avg@icyb.net.ua)
Message-ID: <4A0D6276.2080902@icyb.net.ua>
Date: Fri, 15 May 2009 15:39:18 +0300
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.21 (X11/20090406)
MIME-Version: 1.0
To: freebsd-fs@freebsd.org
References: <4A0D48CB.7030707@icyb.net.ua> <4A0D5E64.1050500@icyb.net.ua>
In-Reply-To: <4A0D5E64.1050500@icyb.net.ua>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Pawel Jakub Dawidek <pjd@freebsd.org>
Subject: Re: stable/7: shutdown stuck in zfs_umount (z_op_cnt > 0)
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 May 2009 12:39:21 -0000

on 15/05/2009 15:21 Andriy Gapon said the following:
> Red herring or not (I don't see the general picture of zfs code), but it seems
> that there is no ZFS_EXIT for return at the end of zfsctl_snapdir_lookup function.
> 
> P.S. C++ RAII could have been handy in this case [or not] :-)

Couple of notes:
1. this doesn't appear to be a red herring as ZFS_EXIT before the last return
statement can be found in head
2. yes, I do mount snapshots from time to time (backups, etc)


-- 
Andriy Gapon