From owner-freebsd-current@FreeBSD.ORG Sun Sep 30 23:16:22 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7EA116A418 for ; Sun, 30 Sep 2007 23:16:22 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 3B3D313C468 for ; Sun, 30 Sep 2007 23:16:21 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.1/8.14.1/ALCHEMY.FRANKEN.DE) with ESMTP id l8UNGK3I081596; Mon, 1 Oct 2007 01:16:20 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.1/8.14.1/Submit) id l8UNGKbr081595; Mon, 1 Oct 2007 01:16:20 +0200 (CEST) (envelope-from marius) Date: Mon, 1 Oct 2007 01:16:20 +0200 From: Marius Strobl To: Marcel Moolenaar Message-ID: <20070930231620.GD55741@alchemy.franken.de> References: <20070930114914.GB38896@alchemy.franken.de> <47001D02.4080700@protected-networks.net> <20070930221748.GC55741@alchemy.franken.de> <0FE79DBF-2E3B-4785-B192-666E02BFFB6D@mac.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0FE79DBF-2E3B-4785-B192-666E02BFFB6D@mac.com> User-Agent: Mutt/1.4.2.3i Cc: Michael Butler , current@freebsd.org Subject: Re: HEADS UP: [cvs commit: src UPDATING src/share/man/man4 pci.4 src/share/man/man9 pci.9 src/sys/amd64/include legacyvar.h src/sys/amd64/amd64 legacy.c src/sys/amd64/pci pci_bus.c src/sys/arm/xscale/i80321 i80321_pci.c src/sys/arm/xscale/ixp425 ... X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 23:16:22 -0000 On Sun, Sep 30, 2007 at 03:34:57PM -0700, Marcel Moolenaar wrote: > On Sep 30, 2007, at 3:17 PM, Marius Strobl wrote: > > >>Where it would previously succeed, I now get .. > >> > >>toshi# pciconf -wb pci0:30:0 0x1a 8 > >>pciconf: ioctl(PCIOCWRITE): Operation not supported by device > >> > > > >As mentioned the format of the location strings has changed, > >you probably need to use pci0:0:30:0. > > If compatibility is a concern, we may be able to make the parsing > a bit more smart without too much complexity. We can count the > number of colons for exampl,e and assume missing elements are 0. > So, if one enters pci1:2:3, the domain will be 0. If one enters > pci4:5, both the domain and bus will be 0, etc. > > Just a thought... > Unfortunately, for pciconf(8) the function is already optional so pci1:2:3 would be ambiguous. Originally my plan was to strip the 'pci' for strings specifing a location including a domain and keep the pcib:s:f format for backwards compatibility, but John was against this as he wants the format to be uniform with the strings used for a hints feature he is working on and which in turn relies on the 'pci' part. Marius