From nobody Thu Nov 2 18:47:41 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SLtCx6LL5z503nB; Thu, 2 Nov 2023 18:47:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SLtCx5ts6z3WNF; Thu, 2 Nov 2023 18:47:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698950861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C+4UYcux8vBwd1wisUW9BNxV0YgVYGBTuNdv5vTatMs=; b=yUAj79nkwVergh4dW7MMcvGyr8gHjQIn+xtmHsanhpRbQ0U/cztAdkmCwe2MyjR6D3aCwY gqNI27MkWz7kMJk+2K/BphL/IevYz6mhMfmDtRejs/J0AclGD1zEMv3kau/G83DkBUyH+L 1f7ummV/j+5pmqNXv9FNExFOKIu56I8oIxgDkxTcez1W0NxT4JW+/gC0ilLr3vX/O73vzB Ot4zN/xLisXi++9Ggst/dH+pzPwjY7gpqVe1IPziTgzdW6QwcGn5REB7J99UUPScKW+w5d 2ArI38Jv1mM0SES5ZzHHONwPH2GFC7TQenHmY5X4yq7ylXW8spf0VDFq9YRmLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698950861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C+4UYcux8vBwd1wisUW9BNxV0YgVYGBTuNdv5vTatMs=; b=WgWo6lq95C109Dc6KED11MW+n13ma0FK4+nDppIW3xcVa3kehuyw9MuOi6nBdZzJ6meabQ 5ONz96NM1B2/9z/6jFkvIQ5hiCUqnC4FYlMMZw6AgSdVdmBV6NGNwJrgfAJJ4a4h2vqZSY FhgPnNHbX94w6POfvUOMBChYzgkts9iCpWmzIj6yb6OAi2+I5+FlL4nIVpUcz60cmwLf7i PRFGCmA4LhwqTkz2tnGOng8FMeneDaur1BXCtHV+k7MUewF1Z9CpZ14ATPkG12ZVNQt1oO OTyCbGbrDmMHjVd2pB13U/PnK3It7yYfP/ed/pqe4cfXsExTDpufOWCHN7NAjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698950861; a=rsa-sha256; cv=none; b=OberL3JPE/0M8+oiiul5opWHiNSfAB9ZXhA1NM+yO54+8Vs3e9QKIf2LMhsks250zI13g4 okq+IianJfuvd1b8ThvW2xk+IhNlr/ggR6+ExorzRewnazUe2pEQMspHLP224neizVmkdO c3ymzE9+jvMwLe8D73KAO/M0y6u9NmUbywGYzyTtNx2A1oZMkHmgzallGwS8a1zClr2pmn s4sO8tXBhv+YVFeS20ZXJST5UawEINKhWOVDa49/LVQSotnduCRTK01aploVFae/pBkX20 jb1nsodJ8pHCLC/+IS/NFT9wSjZRDwoh9V5mm3aO2M1wIDNx0z0hsK31uU6eiA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SLtCx4x01zgkS; Thu, 2 Nov 2023 18:47:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3A2IlfcG044558; Thu, 2 Nov 2023 18:47:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3A2IlfxH044554; Thu, 2 Nov 2023 18:47:41 GMT (envelope-from git) Date: Thu, 2 Nov 2023 18:47:41 GMT Message-Id: <202311021847.3A2IlfxH044554@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 2b084923824e - main - amd64: Remove PMAP_INLINE List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2b084923824e0d5133fe5aff580b4e562fe7dd19 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=2b084923824e0d5133fe5aff580b4e562fe7dd19 commit 2b084923824e0d5133fe5aff580b4e562fe7dd19 Author: Mark Johnston AuthorDate: 2023-11-02 18:30:10 +0000 Commit: Mark Johnston CommitDate: 2023-11-02 18:30:10 +0000 amd64: Remove PMAP_INLINE With clang it expands to "inline"; clang in practice may inline externally visible functions even without the hint. So just remove the hints and let the compiler decide. No functional change intended. pmap.o is identical before and after this patch. Reviewed by: alc MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D42446 --- sys/amd64/amd64/pmap.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/sys/amd64/amd64/pmap.c b/sys/amd64/amd64/pmap.c index cc463832babf..3b009385aaab 100644 --- a/sys/amd64/amd64/pmap.c +++ b/sys/amd64/amd64/pmap.c @@ -338,16 +338,6 @@ safe_to_clear_referenced(pmap_t pmap, pt_entry_t pte) return (FALSE); } -#if !defined(DIAGNOSTIC) -#ifdef __GNUC_GNU_INLINE__ -#define PMAP_INLINE __attribute__((__gnu_inline__)) inline -#else -#define PMAP_INLINE extern inline -#endif -#else -#define PMAP_INLINE -#endif - #ifdef PV_STATS #define PV_STAT(x) do { x ; } while (0) #else @@ -1560,7 +1550,7 @@ pt_entry_t vtoptem __read_mostly = ((1ul << (NPTEPGSHIFT + NPDEPGSHIFT + NPDPEPGSHIFT + NPML4EPGSHIFT)) - 1) << 3; vm_offset_t PTmap __read_mostly = (vm_offset_t)P4Tmap; -PMAP_INLINE pt_entry_t * +pt_entry_t * vtopte(vm_offset_t va) { KASSERT(va >= VM_MAXUSER_ADDRESS, ("vtopte on a uva/gpa 0x%0lx", va)); @@ -3623,7 +3613,7 @@ pmap_invalidate_all(pmap_t pmap) } } -PMAP_INLINE void +void pmap_invalidate_cache(void) { @@ -3980,7 +3970,7 @@ pmap_kextract(vm_offset_t va) * Add a wired page to the kva. * Note: not SMP coherent. */ -PMAP_INLINE void +void pmap_kenter(vm_offset_t va, vm_paddr_t pa) { pt_entry_t *pte; @@ -4006,7 +3996,7 @@ pmap_kenter_attr(vm_offset_t va, vm_paddr_t pa, int mode) * Remove a page from the kernel pagetables. * Note: not SMP coherent. */ -PMAP_INLINE void +void pmap_kremove(vm_offset_t va) { pt_entry_t *pte;