From owner-svn-src-head@freebsd.org Wed Feb 26 21:56:01 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3FA71247E8E; Wed, 26 Feb 2020 21:56:01 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SV3z59jnz3xDC; Wed, 26 Feb 2020 21:55:59 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id 01QLtpW1086817 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 26 Feb 2020 13:55:51 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id 01QLto6j086816; Wed, 26 Feb 2020 13:55:50 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Wed, 26 Feb 2020 13:55:50 -0800 From: Gleb Smirnoff To: Ravi Pokala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358317 - head/sys/kern Message-ID: <20200226215550.GO5741@FreeBSD.org> References: <202002251911.01PJBLDP091875@repo.freebsd.org> <23A820B4-2E13-4E3E-B734-C7950298C286@panasas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23A820B4-2E13-4E3E-B734-C7950298C286@panasas.com> X-Rspamd-Queue-Id: 48SV3z59jnz3xDC X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.65 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.66)[-0.661,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; NEURAL_HAM_LONG(-0.99)[-0.988,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 21:56:01 -0000 On Tue, Feb 25, 2020 at 12:02:29PM -0800, Ravi Pokala wrote: R> When sendfile_swapin() sweeps through pages in search for a bogus page R> skip first and last pages. This is a micro optimisation. R> R> Yes, but *why* skip the first and last pages? We may have inserted bogus pages in the middle of a request. We never substitute first or last. -- Gleb Smirnoff