From owner-freebsd-current  Sun Mar  2 12:12: 7 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 03DFE37B401
	for <current@FreeBSD.ORG>; Sun,  2 Mar 2003 12:12:06 -0800 (PST)
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2D14243FA3
	for <current@FreeBSD.ORG>; Sun,  2 Mar 2003 12:12:05 -0800 (PST)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1])
	by khavrinen.lcs.mit.edu (8.12.6/8.12.6) with ESMTP id h22KC3pI075569
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK);
	Sun, 2 Mar 2003 15:12:03 -0500 (EST)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.12.6/8.12.6/Submit) id h22KC33h075566;
	Sun, 2 Mar 2003 15:12:03 -0500 (EST)
	(envelope-from wollman)
Date: Sun, 2 Mar 2003 15:12:03 -0500 (EST)
From: Garrett Wollman <wollman@lcs.mit.edu>
Message-Id: <200303022012.h22KC33h075566@khavrinen.lcs.mit.edu>
To: Bruce Evans <bde@zeta.org.au>
Cc: current@FreeBSD.ORG
Subject: Re: PATCH: typo in socreate() or i'm missing something
In-Reply-To: <20030301202521.D25845-100000@gamplex.bde.org>
References: <3E5FA9B0.90306@exodus.net>
	<20030301202521.D25845-100000@gamplex.bde.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

<<On Sat, 1 Mar 2003 22:18:12 +1100 (EST), Bruce Evans <bde@zeta.org.au> said:

> Interestingly, socreate() in Lite2 always does a can-wait malloc() so
> our current soalloc(M_NOWAIT) does the same thing as Lite2 and is only
> wrong if the FreeBSD change from can-wait to "can-wait-if p != 0"
> change was needed and is still needed.

When I initially revamped that code, I waited unconditionally and was
rewarded with an appropriate panic for sleeping in interrupt context.
I cannot speak as to whether it is still needed.

-GAWollman


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message