From owner-svn-src-head@FreeBSD.ORG  Fri Jun  8 18:48:43 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EDEBA106566B;
	Fri,  8 Jun 2012 18:48:43 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
	by mx1.freebsd.org (Postfix) with ESMTP id A1ED38FC1A;
	Fri,  8 Jun 2012 18:48:43 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:6c85:f675:d0b9:5b63] (unknown
	[IPv6:2001:7b8:3a7:0:6c85:f675:d0b9:5b63])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id 36B565C37;
	Fri,  8 Jun 2012 20:48:37 +0200 (CEST)
Message-ID: <4FD24906.8080209@FreeBSD.org>
Date: Fri, 08 Jun 2012 20:48:38 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:13.0) Gecko/20120529 Thunderbird/13.0
MIME-Version: 1.0
To: Gabor Kovesdan <gabor@FreeBSD.org>
References: <201206081708.q58H8RRw072192@svn.freebsd.org>
	<4FD2369D.6040503@FreeBSD.org>
In-Reply-To: <4FD2369D.6040503@FreeBSD.org>
X-Enigmail-Version: 1.5a1pre
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r236759 - head/usr.bin/sort
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2012 18:48:44 -0000

On 2012-06-08 19:30, Gabor Kovesdan wrote:
> On 2012.06.08. 19:08, Dimitry Andric wrote:
...
>> -#define	UNUSED_ARG(A) do { A=A; } while(0)
>> +#define	UNUSED_ARG(A) do { (void)(A); } while(0)
> My fault, I should have fixed this. But what about this version? I think 
> it is more elegant and this is how it should have been done initially:

No worries, I just used the least disruptive way of fixing it.  Note
that it also only occurs specifically when you compile with -save-temps
or with ccache, which does preprocessing and compiling separately.

Your new diff looks good to me.  Though please attach diffs next time,
for some reason your mail client (or mine) badly mangled the tabs, and
it was tricky to apply. :)