From owner-freebsd-ports@FreeBSD.ORG  Mon Dec  6 02:34:44 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BE62A106566C
	for <freebsd-ports@freebsd.org>; Mon,  6 Dec 2010 02:34:44 +0000 (UTC)
	(envelope-from lists@eitanadler.com)
Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 920418FC08
	for <freebsd-ports@freebsd.org>; Mon,  6 Dec 2010 02:34:44 +0000 (UTC)
Received: by iwn39 with SMTP id 39so14072138iwn.13
	for <freebsd-ports@freebsd.org>; Sun, 05 Dec 2010 18:34:43 -0800 (PST)
Received: by 10.231.17.4 with SMTP id q4mr5218519iba.119.1291602882934; Sun,
	05 Dec 2010 18:34:42 -0800 (PST)
MIME-Version: 1.0
Received: by 10.231.79.82 with HTTP; Sun, 5 Dec 2010 18:34:22 -0800 (PST)
In-Reply-To: <AANLkTi=fX4YsGdF=YatWFNzsrgkvD5QK0GDg+dzukv9k@mail.gmail.com>
References: <AANLkTi=fX4YsGdF=YatWFNzsrgkvD5QK0GDg+dzukv9k@mail.gmail.com>
From: Eitan Adler <lists@eitanadler.com>
Date: Sun, 5 Dec 2010 21:34:22 -0500
Message-ID: <AANLkTim3SpdVfuT1uNuAkkPe1LgwswfcGmXTa0j_3CZG@mail.gmail.com>
To: freebsd ports <freebsd-ports@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [patch] Re: A few questions about bsd.port.mk
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Dec 2010 02:34:44 -0000

On Thu, Dec 2, 2010 at 5:49 PM, Eitan Adler <lists@eitanadler.com> wrote:
> I noticed a line in bsd.port.mk "Kludge for pre-3.0 systems"
>
> # Kludge for pre-3.0 ystems
> MACHINE_ARCH?=3D =C2=A0 =C2=A0 =C2=A0 i386
>
> According to cvs blame asami@ added both lines in revision 1.306 in 1999
>
> Furthermore in bsd.port.mk it says ports should test against ARCH and
> not MACHINE_ARCH
> but bsd.port.subdir.mk uses MACHINE_ARCH on line 209.
>
> bsd.gnustep.mk has a similar test for MACHINE_ARCH instead of ARCH on
> line 136 (r1.1 by dinoex)
>
> 1) Should the initial line be removed
> 2) Should bsd.port.subdir.mk be changed to use ARCH instead?
> 3) Should bsd.gnustep.mk be changed to use ARCH instead?

Here is a completely untested patch that makes the changes above.
http://isis.poly.edu/~eitan/files/remove-2004-hack.patch
Comments on both the patch and my questions are appreciated.


--=20
Eitan Adler