Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Feb 2008 10:37:36 +0000
From:      Craig Rodrigues <rodrigc@crodrigues.org>
To:        Yar Tikhiy <yar@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/mount_nfs mount_nfs.c
Message-ID:  <20080218103736.GA79284@crodrigues.org>
In-Reply-To: <200802181024.m1IAOmoF089632@repoman.freebsd.org>
References:  <200802181024.m1IAOmoF089632@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 18, 2008 at 10:24:48AM +0000, Yar Tikhiy wrote:
>   The real solution would be to bring the whole nmount(2)
>   framework, including FS drivers and userland tools, into
>   a consistent state at last; but things should work in the
>   meantime, too.

When I read comments like this, I have the feeling
that you are doing drive-by-commits to areas where you do
not understand the full implications of what you are doing.

Can you slow down on your commits to the mount code, and try
to post more of your patches to mailing lists so other people
can review them and try them out?  You've indicated to me
that you don't have time to fully test out and implement the
necessary changes to fix all the file systems and userland code
in FreeBSD related to mounting file systems.

While I appreciate your efforts to deal with PR's and fix things,
the mount code is a tangled web, and it is very easy to introduce
subtle errors in unrelated areas by committing what appear
to be "obvious fixes".  This has happened to a few people (including
me) in the past.

-- 
Craig Rodrigues
rodrigc@crodrigues.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080218103736.GA79284>