From owner-cvs-src@FreeBSD.ORG Fri Aug 1 12:28:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F9AF37B401; Fri, 1 Aug 2003 12:28:50 -0700 (PDT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 243AD43F75; Fri, 1 Aug 2003 12:28:49 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h71JSlkM004244; Fri, 1 Aug 2003 15:28:47 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200307251840.h6PIea2N049887@repoman.freebsd.org> References: <200307251840.h6PIea2N049887@repoman.freebsd.org> Date: Fri, 1 Aug 2003 15:28:46 -0400 To: Garance A Drosehn , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/sys/sys cdefs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2003 19:28:50 -0000 At 11:40 AM -0700 7/25/03, Garance A Drosehn wrote: > > Modified files: > sys/sys cdefs.h > > Log: > [...] the "do-nothing" versions of __RCSID(), __RCSID_SOURCE(), > __SCCSID(), and __COPYRIGHT() were not strictly correct. [...] > > So, change the do-nothing versions of those macros to use the > 'struct __hack' tactic, as was already used with __FBSDID(). > > Approved by: discussions with bde > MFC after: 1 week Just an update on this: Looking at the version of sys/cdefs.h in 4.x-stable, it does not even have the do-nothing versions of the above macros. So, I think I'll just skip the MFC of this, unless people want me to add the do-nothing versions of the above macros. (4.x-stable does have the do-nothing version of __FBSDID, but it already uses 'struct __hack' so there's nothing to do for that) -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu