From owner-freebsd-bugs@FreeBSD.ORG  Sat Nov 15 02:40:16 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8669C16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 15 Nov 2003 02:40:16 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0057D43F3F
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 15 Nov 2003 02:40:15 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hAFAeFFY053714
	for <freebsd-bugs@freefall.freebsd.org>;
	Sat, 15 Nov 2003 02:40:15 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hAFAeFo3053713;
	Sat, 15 Nov 2003 02:40:15 -0800 (PST)
	(envelope-from gnats)
Date: Sat, 15 Nov 2003 02:40:15 -0800 (PST)
Message-Id: <200311151040.hAFAeFo3053713@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Tim Robbins <tjr@freebsd.org>
Subject: Re: kern/59211: System crashes when moving files from NWFS mounted
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Tim Robbins <tjr@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Nov 2003 10:40:16 -0000

The following reply was made to PR kern/59211; it has been noted by GNATS.

From: Tim Robbins <tjr@freebsd.org>
To: Navoyenok Sergei <nasa@les.veco.ru>
Cc: bug-followup@freebsd.org
Subject: Re: kern/59211: System crashes when moving files from NWFS mounted
Date: Sat, 15 Nov 2003 21:38:40 +1100

 Can you try this patch (against RELENG_4)? This could be the same bug
 I fixed in smbfs_vnops.c 1.2.2.8. I haven't tested this since I don't
 have a working netware setup anymore.
 
 
 Index: nwfs_vnops.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/nwfs/Attic/nwfs_vnops.c,v
 retrieving revision 1.6.2.3
 diff -u -r1.6.2.3 nwfs_vnops.c
 --- nwfs_vnops.c	14 Mar 2001 11:26:59 -0000	1.6.2.3
 +++ nwfs_vnops.c	15 Nov 2003 10:27:49 -0000
 @@ -577,20 +577,22 @@
  		vput(tvp);
  	vrele(fdvp);
  	vrele(fvp);
 -	nwfs_attr_cacheremove(fdvp);
 -	nwfs_attr_cacheremove(tdvp);
 -	/*
 -	 * Need to get rid of old vnodes, because netware will change
 -	 * file id on rename
 -	 */
 -	vgone(fvp);
 -	if (tvp)
 -		vgone(tvp);
  	/*
  	 * Kludge: Map ENOENT => 0 assuming that it is a reply to a retry.
  	 */
  	if (error == ENOENT)
  		error = 0;
 +	if (error == 0) {
 +		nwfs_attr_cacheremove(fdvp);
 +		nwfs_attr_cacheremove(tdvp);
 +		/*
 +		 * Need to get rid of old vnodes, because netware will change
 +		 * file id on rename
 +		 */
 +		vgone(fvp);
 +		if (tvp)
 +			vgone(tvp);
 +	}
  	return (error);
  }