From owner-freebsd-stable@FreeBSD.ORG Mon Aug 31 19:30:52 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC3331065676 for ; Mon, 31 Aug 2009 19:30:51 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-px0-f179.google.com (mail-px0-f179.google.com [209.85.216.179]) by mx1.freebsd.org (Postfix) with ESMTP id A848A8FC1A for ; Mon, 31 Aug 2009 19:30:51 +0000 (UTC) Received: by pxi9 with SMTP id 9so294234pxi.14 for ; Mon, 31 Aug 2009 12:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=aVCp5AE/52HEC2eRXDqN99Rw3GDEJq2kalQBBvy2OMU=; b=oyRChdlRI/6zDQyxOVmHPG4FLfzLWtrgqDxvwlUC6GGnZTNXIZ/gnQqMlHcojXxsti UuZTehjMA7R8Ab+gvMjIS4P+1JOD072is0tPDXdDGyw4OKK8dYHJ/7Y0S8yZBuOseu0i amigEdAovjTgrAE+98s80E20MESVEBUhkQPrg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=HgwRIQgYSWtnQeDJk/I0WLkwz0oHV2ViaAwMzWBKmEXuQqv3sj95Vjmc5t21XSlLun bgHyCdzfMuCQ5qpZEA7VYclJC6gvYC6aDZhcuWCcQdNNSmKp4FjKLP1LdqlS89SXN87Z u1Q8G299aNnWjOURpwC61Kc7oqujQd1IIv4E4= Received: by 10.115.39.23 with SMTP id r23mr3121857waj.2.1251747050764; Mon, 31 Aug 2009 12:30:50 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id v39sm2789529wah.27.2009.08.31.12.30.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 31 Aug 2009 12:30:50 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 31 Aug 2009 12:29:20 -0700 From: Pyun YongHyeon Date: Mon, 31 Aug 2009 12:29:20 -0700 To: Jeff Blank Message-ID: <20090831192920.GA2190@michelle.cdnetworks.com> References: <20090831172917.GA1512@mr-happy.com> <20090831174918.GA1258@michelle.cdnetworks.com> <20090831182910.GA96366@mr-happy.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline In-Reply-To: <20090831182910.GA96366@mr-happy.com> User-Agent: Mutt/1.4.2.3i Cc: freebsd-stable@freebsd.org Subject: Re: 8.0-BETA3 and txp(4) panic: vm_phys_alloc_contig X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 19:30:52 -0000 --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 31, 2009 at 02:29:10PM -0400, Jeff Blank wrote: > On Mon, Aug 31, 2009 at 10:49:18AM -0700, Pyun YongHyeon wrote: > > Hmm, this is odd. I can't find where the alignment is not power of > > 2 in txp_dma_alloc(). Could you show me the line number of > > txp_attach+0x6f5? > > What's the command to do this? I thought it might be > 'x/A txp_attach+0x65f', but that gave me nothing. (I don't > have a crash dump to work with, just a serial console and ddb.) > Hmm... never mind. Please try attached patch let me know how it goes. > Jeff --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="txp.align.fix" Index: sys/dev/txp/if_txp.c =================================================================== --- sys/dev/txp/if_txp.c (revision 196606) +++ sys/dev/txp/if_txp.c (working copy) @@ -1389,7 +1389,8 @@ /* High priority rx ring. */ error = txp_dma_alloc(sc, "hi priority rx ring", - &sc->sc_cdata.txp_rxhiring_tag, sizeof(struct txp_rx_desc), 0, + &sc->sc_cdata.txp_rxhiring_tag, + roundup(sizeof(struct txp_rx_desc), 16), 0, &sc->sc_cdata.txp_rxhiring_map, (void **)&sc->sc_ldata.txp_rxhiring, sizeof(struct txp_rx_desc) * RX_ENTRIES, &sc->sc_ldata.txp_rxhiring_paddr); @@ -1409,7 +1410,8 @@ /* Low priority rx ring. */ error = txp_dma_alloc(sc, "low priority rx ring", - &sc->sc_cdata.txp_rxloring_tag, sizeof(struct txp_rx_desc), 0, + &sc->sc_cdata.txp_rxloring_tag, + roundup(sizeof(struct txp_rx_desc), 16), 0, &sc->sc_cdata.txp_rxloring_map, (void **)&sc->sc_ldata.txp_rxloring, sizeof(struct txp_rx_desc) * RX_ENTRIES, &sc->sc_ldata.txp_rxloring_paddr); --G4iJoqBmSsgzjUCe--