From owner-svn-src-head@freebsd.org Fri Jan 11 18:04:23 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16B521497252 for ; Fri, 11 Jan 2019 18:04:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A2EB1764BB for ; Fri, 11 Jan 2019 18:04:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x832.google.com with SMTP id u47so19786286qtj.6 for ; Fri, 11 Jan 2019 10:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s/KKFa/7Yz7+jcb1fsB5RiVL+yfD3LIGRcv8IKUeK3E=; b=WlTM8s7zs6UOUBTY78USlm9qtd7+8Em9DM3HvA6JrCMP/9RNNWdVYUHS84dvGohnJ8 OlntPW2GkgokrPqIUgZ4FvkCsPHl8+2ALLBv4JV/UXvKr7KxnXvlvEjXcGMnQhamvUKV T9Owgs/OAy/g8sEycGgJNgdgBRlki+BdeXzwfSf7qgOxn7R9AKtWu1TESLohTt4ZC49Z eF7VayJVUB07Tm9tEdwsw5QqL0ufFM1Z8Jcw2Vl1oWiQ1ccNwM/AtyMT2mr3RZ4RYl/p 4KopFRukRoljAuGxsGRsI/ys9Qkdp/4IhC6rAsCldzaOtNPwCr1dqsmLk/27A9NGE68B dB8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s/KKFa/7Yz7+jcb1fsB5RiVL+yfD3LIGRcv8IKUeK3E=; b=FeFytTKMaabBwI/NH227DVDK9qM4HOESOQuEjCrOf7V7qpQkme3zvkfljFzeuFKyMu 3aMrMW8CAxKLYKk3uabc11suN+DUtU2KRwi9kMELy7HFhT7WyhSs3L+3XTQERaoELJ2m fJeVfHjRzOa2CmmHmmGr0bOx7+4RMHMXmho2wj9EkALFpxOCJWrfFlec0c3otRq2VEJO 2ANxYaizSmS7UJk5AXtnwCMGb9rhdpv0+d1N5tUwR64W6jd/FyDzxqpFg6eW3ukWW7kX TmVSF6ErEaliunzU/cS0lhkYhMLBa8tV+qbbZ6GMa/tLsRI2rkVhjdXb6XalbyX6UCUu 18Ow== X-Gm-Message-State: AJcUukdYL4lIfkowz+RRCforTi/+eVY6dmzpb/yGNBSMtc6bKSkMiE+w 1DagZPYzc9dxNZD0fiyaog0aIiT4y1Hg6n4qggWB9w== X-Google-Smtp-Source: ALg8bN44ehNIZxp7WUw6MLASqmqGtHY8lHDlZ+zP0TL1iAZnY3gmyvJCpyMe9Tyu+w3MfEhibUPALWXvmYYSKWLCCX0= X-Received: by 2002:a0c:f143:: with SMTP id y3mr15113784qvl.21.1547229861995; Fri, 11 Jan 2019 10:04:21 -0800 (PST) MIME-Version: 1.0 References: <20190111164754.GB1267@e.0x20.net> <201901111710.x0BHAXsr022139@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201901111710.x0BHAXsr022139@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Fri, 11 Jan 2019 11:04:10 -0700 Message-ID: Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config To: "Rodney W. Grimes" Cc: Lars Engels , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: A2EB1764BB X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 18:04:23 -0000 On Fri, Jan 11, 2019 at 10:10 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: > > > The style of this .sh does not match the normal style of > > > such things in base, especially with respect to long lines > > > and indentation. > > > > Do we have a style guide for shell scripts in base? How should > > indentation look like? > > Not that I can locate, but I can state that almost all > of the base code uses tab indenting and limited to 80 > column widths, independent of c, sh, make, etc. > We have a style.Makefile, style, style.mdoc and style.lua man pages. Maybe it's time for style.sh, eh? Warner