From owner-freebsd-current@FreeBSD.ORG  Tue Sep  7 03:47:28 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A5BB716A4CE
	for <freebsd-current@freebsd.org>;
	Tue,  7 Sep 2004 03:47:28 +0000 (GMT)
Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7B84443D54
	for <freebsd-current@freebsd.org>;
	Tue,  7 Sep 2004 03:47:28 +0000 (GMT)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: (qmail 17278 invoked from network); 7 Sep 2004 03:47:28 -0000
Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168])
          (envelope-sender <jmg@hydrogen.funkthat.com>)
          by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <pepper@reppep.com>; 7 Sep 2004 03:47:28 -0000
Received: from hydrogen.funkthat.com (xgpkda@localhost.funkthat.com
	[127.0.0.1])i873lSuU092297;	Mon, 6 Sep 2004 20:47:28 -0700 (PDT)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: (from jmg@localhost)
	by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i873lRoi092296;
	Mon, 6 Sep 2004 20:47:27 -0700 (PDT)
Date: Mon, 6 Sep 2004 20:47:27 -0700
From: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
To: Chris Pepper <pepper@reppep.com>, freebsd-current@freebsd.org
Message-ID: <20040907034727.GH72089@funkthat.com>
Mail-Followup-To: Chris Pepper <pepper@reppep.com>,
	freebsd-current@freebsd.org
References: <20040825175250.GO29902@funkthat.com>
	<p06200b06bd617d76dcd9@[10.0.1.103]> <20040907034057.GG72089@funkthat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040907034057.GG72089@funkthat.com>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 4.2-RELEASE i386
X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31  96 7A 22 B3 D8 56 36 F4
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
Subject: Re: if_re locking patch...
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Sep 2004 03:47:28 -0000

John-Mark Gurney wrote this message on Mon, Sep 06, 2004 at 20:40 -0700:
> Chris Pepper wrote this message on Mon, Sep 06, 2004 at 23:32 -0400:
> > 	Unfortunately "make buildkernel" fails on if_re with 
> > DEVICE_POLLING, which should work according to polling.4.
> > 
> > http://www.reppep.com/~pepper/guest/make-buildkernel-re-failure-2.txt
> 
> ru committed a fix for this already...  but it appears to have failed
> to be MFC'd...  I didn't expect the change to be MFC'd so quickly...
> I'll make sure that the fix gets MT5..

Let me correct the record, this change has not been MFC'd yet, and ru
commited the fix to -current.  Basicly add semicolons at the end of the
prototypes that are ifdef'd DEVICE_POLLING out..

I have updated the patch, or you can grab HEAD's if_re.c.

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."