From owner-cvs-src@FreeBSD.ORG  Thu Mar 20 20:21:11 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A387710656C2;
	Thu, 20 Mar 2008 20:21:11 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 8D6D08FC18;
	Thu, 20 Mar 2008 20:21:11 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 659C71A4D84; Thu, 20 Mar 2008 13:21:11 -0700 (PDT)
Date: Thu, 20 Mar 2008 13:21:11 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Doug Rabson <dfr@rabson.org>
Message-ID: <20080320202111.GT67856@elvis.mu.org>
References: <200803191233.m2JCXPRp070753@repoman.freebsd.org>
	<20080320025645.GI67856@elvis.mu.org>
	<F042E351-95A3-4C9A-92AF-878CB0F93EBE@rabson.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F042E351-95A3-4C9A-92AF-878CB0F93EBE@rabson.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@FreeBSD.org, Doug Rabson <dfr@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsserver nfs_srvsock.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Mar 2008 20:21:11 -0000

* Doug Rabson <dfr@rabson.org> [080320 01:44] wrote:
> 
> On 20 Mar 2008, at 02:56, Alfred Perlstein wrote:
> 
> >* Doug Rabson <dfr@FreeBSD.org> [080319 05:32] wrote:
> >>dfr         2008-03-19 12:33:25 UTC
> >>
> >> FreeBSD src repository
> >>
> >> Modified files:
> >>   sys/nfsserver        nfs_srvsock.c
> >> Log:
> >> Fix a regression from the last revision - don't edit the ns_rec  
> >>list while
> >> not holding the lock.
> >>
> >> Revision  Changes    Path
> >> 1.107     +3 -1      src/sys/nfsserver/nfs_srvsock.c
> >
> >This function should have a WITNESS check at the top of it.
> >
> >Can you add it?  If not I will unless you see a problem with
> >it.
> 
> The various WITNESS_* macros appear to be undocumented and I'm not  
> sure what they do. Perhaps it would be best if you added something.
> 

Ok, will get to it shortly.

thank you,
-- 
- Alfred Perlstein