From owner-dev-commits-doc-all@freebsd.org Tue Dec 15 22:15:20 2020 Return-Path: Delivered-To: dev-commits-doc-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D40FB4C5EF4 for ; Tue, 15 Dec 2020 22:15:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CwXd45Sv9z3HfJ; Tue, 15 Dec 2020 22:15:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:a4c5:833e:8ae:3fad]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4DA0A1615; Tue, 15 Dec 2020 22:15:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 072b13ec97 - configure arcanist for the git world To: Eitan Adler Cc: doc-committers@freebsd.org, dev-commits-doc-all@freebsd.org References: <202012131652.0BDGqb5k033036@gitrepo.freebsd.org> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <983694ab-b822-90a7-72a9-1addd0ae7774@FreeBSD.org> Date: Tue, 15 Dec 2020 14:15:18 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-doc-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the doc repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 22:15:20 -0000 On 12/15/20 12:39 AM, Eitan Adler wrote: > On Mon, 14 Dec 2020 at 11:07, John Baldwin wrote: >> >> On 12/13/20 8:52 AM, Eitan Adler wrote: >>> The branch main has been updated by eadler: >>> >>> URL: https://cgit.FreeBSD.org/doc/commit/?id=072b13ec97b32d91379f5c11e577d3509af00e18 >>> >>> commit 072b13ec97b32d91379f5c11e577d3509af00e18 >>> Author: Eitan Adler >>> AuthorDate: 2020-12-13 16:52:31 +0000 >>> Commit: Eitan Adler >>> CommitDate: 2020-12-13 16:52:31 +0000 >>> >>> configure arcanist for the git world >>> >>> Problem >>> >>> The documentation ("doc") repository has been converted to git but >>> arcanist does not yet understand how to interact with phabricator in >>> this world. >> >> The callsign is still needed for folks who make a private clone and do work >> in branches of that. For example, my workflow in src post-conversion will >> still consist of branches off of github.com/bsdjhb/*.git that are then >> pushed into arc and only pushed up to the actual upstream after review. > > This should not be required as long as you have the true origin as one > of the remotes. I _explicitly_ tested this case. If this isn't > working can you please run `arc which` on the broken case? Yes, but not everyone will have the upstream as a remote. If I'm a non-committer, I might clone the repository on GH or the like and work on a branch in my own clone and have that clone as my only remote when I then upload a diff via 'arc diff --create'. I don't really see the harm in having the repository explicit in the .arcconfig. >>> Solution >>> >>> - remove the callsign "D" which should be inferable from having one of >>> the cgit URLs as a remote >>> - remove "history.immutable" which was a workflow only required for >>> subversion >> >> I don't know that we want all of the arcanist-formatted data in our commit >> logs. Adding the DR URL automatically might be welcome, but I don't know >> that we want arcanist's format for Reviewers, Reviewed By, etc > > Agreed: though there are tradeoffs here. history.immutable=true has > several other implications which go against our workflow. Specifically > it will result in `arc land` using merge commits instead of squash > commits Please see > https://secure.phabricator.com/book/phabricator/article/arcanist_new_project/#history-mutability > for details. I've basically assumed we can't quite use 'arc land' due to the way it's commit log format. I won't belabor the point here but instead wait for the arch@ thread. -- John Baldwin