From owner-cvs-src@FreeBSD.ORG Sun Jul 3 01:03:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F079016AA27; Sun, 3 Jul 2005 00:57:24 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6643D44182; Sun, 3 Jul 2005 00:38:49 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 2D2346D928; Sat, 2 Jul 2005 17:37:39 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 59E665C9B8 for ; Sun, 16 Jan 2005 20:29:22 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 976EC56464 for ; Mon, 17 Jan 2005 04:29:21 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id C882216A53D; Mon, 17 Jan 2005 04:29:17 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 7BE6716A4D0; Mon, 17 Jan 2005 04:29:15 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B913A16A4CE; Mon, 17 Jan 2005 04:29:13 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33ACB43D4C; Mon, 17 Jan 2005 04:29:13 +0000 (GMT) (envelope-from imp@harmony.village.org) Received: from localhost (localhost [IPv6:::1]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id j0H4RJHx037709; Sun, 16 Jan 2005 21:27:19 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <20050116.212718.74715734.imp@harmony.village.org> To: smkelly@FreeBSD.org From: Warner Losh In-Reply-To: <20050116104942.GA39032@edgemaster.zombie.org> References: <200501160101.j0G11FdX014832@repoman.freebsd.org> <20050116104942.GA39032@edgemaster.zombie.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cognet@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bktr bktr_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:03:16 -0000 X-Original-Date: Sun, 16 Jan 2005 21:27:18 -0700 (MST) X-List-Received-Date: Sun, 03 Jul 2005 01:03:16 -0000 From: Sean Kelly Subject: Re: cvs commit: src/sys/dev/bktr bktr_core.c Date: Sun, 16 Jan 2005 04:49:42 -0600 > On Sun, Jan 16, 2005 at 01:01:15AM +0000, Olivier Houchard wrote: > > cognet 2005-01-16 01:01:15 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_5) > > sys/dev/bktr bktr_core.c > > Log: > > MFC rev 1.139: > > revision 1.138 > > date: 2005/01/09 17:42:03; author: cognet; state: Exp; lines: +64 -64 > > Use uint32_t instead of u_long when appropriate. > > That's enough to make my bt848 work on amd64. > > --- src/sys/dev/bktr/bktr_core.c 2004/06/16 09:46:38 1.135 > +++ src/sys/dev/bktr/bktr_core.c 2005/01/16 01:01:14 1.135.2.1 > ... > - if (ioflag & IO_NDELAY) { > + if (ioflag & FNDELAY) { > ... > > This broke my RELENG_5 build. I'd debug it more, but it is approaching 5AM > and only bad things would come of it. It shouldn't have been MFC'd, I don't think, because IO_NDELAY is the right way in 5.x. Warner