Date: Fri, 7 Sep 2007 11:52:29 -0300 From: "William Grzybowski" <william88@gmail.com> To: "Nate Lawson" <nate@root.org> Cc: acpi@freebsd.org, current@freebsd.org Subject: Re: PATCH: ecng for 6.x and 7.x Message-ID: <632825b40709070752o6fe867a2s3e7647e5444b1b5b@mail.gmail.com> In-Reply-To: <46E07AAF.2060000@root.org> References: <46E0777A.8070901@root.org> <46E07AAF.2060000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/6/07, Nate Lawson <nate@root.org> wrote: > > Nate Lawson wrote: > > I've done some major rework on the EC driver. This should help with > > various problems, including timeouts while checking battery status or > > temperature. The attached patches are for 6.x and 7.x. Please test and > > let me know if you get any new errors on dmesg or if it fixes things for > > you (especially HP/Compaq laptop owners). > > > > If you still have problems, try setting each of these tunables > > individually and then both together (i.e., in /boot/loader.conf). Note > > that this will be four (4) test runs total, so don't just set both and > > say it doesn't work. > > > > debug.acpi.ec.burst="1" > > debug.acpi.ec.polled="1" > > > > I've tested both patches on a Panasonic Y4 and UnnamedOEM laptop, no > > problems in either regular or burst mode. > > > > > > Commit message: > > Rewrite the EC driver event model. The main goal is to avoid > > polling/interrupt-driven fallback and instead use polling only during > > boot and pure interrupt-driven mode after boot. Polled mode could be > > relegated completely to a legacy role if we could enable interrupts > > during boot. Polled mode can be forced after boot by setting > > debug.acpi.ec.polled="1", i.e. if there are timeouts. > > One minor note -- power off shutdown (shutdown/halt -p) is turned into a > (safe) reboot with this patch. I have tested the fix, which is just to > force polled mode during shutdown as well. I don't have time to re-roll > the patch today but will send tomorrow. > > Please test the patch as posted, ignoring that minor issue. The test > results during normal use are still valid. > Hi Nate, I tested this patch on my acer notebook (intel chipset) and i did not notice any changes, unless some errors on dmesg, like: acpi_ec0: EcCommand: no response to 0x84 acpi_ec0: GPE query failed: AE_NO_HARDWARE_RESPONSE acpi_ec0: EcCommand: no response to 0x82 acpi_ec0: EcCommand: no response to 0x80 ACPI Error (psparse-0626): Method parse/execution failed [\\_TZ_.THRM._TMP] (Node 0xc3bbdcc0), AE_NO_HARDWARE_RESPONSE ACPI Error (psparse-0626): Method parse/execution failed [\\_SB_.ACAD._PSR] (Node 0xc3bc02a0), AE_NO_HARDWARE_RESPONSE I tried the 4 test runs which you mentioned , when I boot with both debug.acpi (burst and polled = 1) I got a kernel panic but i couldn't save the backtrace, but it was about _sx_xlock_hard in recursed on non-recursive function, line 209 on acpi_ec.c I'm send links for 3 verbose boot's (i couldnt for burst and polled because the panic) if you want to take a look.. http://www.inf.ufpr.br/wg06/dmesg-acpi-ec.gz http://www.inf.ufpr.br/wg06/dmesg-acpi-ec-burst.gz http://www.inf.ufpr.br/wg06/dmesg-acpi-ec-polled.gz Thanks, bye. -- William Grzybowski ------------------------------------------ Jabber: william88 at gmail dot com Curitiba/PR - Brazil
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?632825b40709070752o6fe867a2s3e7647e5444b1b5b>