From owner-cvs-all@FreeBSD.ORG Mon Jan 16 19:12:48 2012 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EED47106566B; Mon, 16 Jan 2012 19:12:48 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward11.mail.yandex.net (forward11.mail.yandex.net [IPv6:2a02:6b8:0:801::1]) by mx1.freebsd.org (Postfix) with ESMTP id 646138FC14; Mon, 16 Jan 2012 19:12:48 +0000 (UTC) Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward11.mail.yandex.net (Yandex) with ESMTP id A9189E82ED6; Mon, 16 Jan 2012 23:12:46 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1326741166; bh=mtSnb+ShoioEoWDqE3vLa6u8xX4HZvAdEQn3f4g8ZF0=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=VA4rpcpTzVSmFt8rWd95pzPZgBianhKRwDsCOsZ93ejVeHlPtkTYcl9jN78ygXJpE gj2kcbQ9Og9yyO6/iN9Vg9/1n/uvg2HqQy4zVMZckKpLLg2Ew+j0etPnzdRJ0BZaAP 1JavteuUlubxhct2wplOB1p4wLF+VKEyjiftg49s= Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id 54EC77E03BA; Mon, 16 Jan 2012 23:12:46 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1326741166; bh=mtSnb+ShoioEoWDqE3vLa6u8xX4HZvAdEQn3f4g8ZF0=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=VA4rpcpTzVSmFt8rWd95pzPZgBianhKRwDsCOsZ93ejVeHlPtkTYcl9jN78ygXJpE gj2kcbQ9Og9yyO6/iN9Vg9/1n/uvg2HqQy4zVMZckKpLLg2Ew+j0etPnzdRJ0BZaAP 1JavteuUlubxhct2wplOB1p4wLF+VKEyjiftg49s= Received: from unknown (unknown [178.76.224.133]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id CjPus2oL-CjPuuLlm; Mon, 16 Jan 2012 23:12:46 +0400 X-Yandex-Spam: 1 Message-ID: <4F14768A.6060701@yandex.ru> Date: Mon, 16 Jan 2012 23:12:10 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: Veniamin Gvozdikov References: <201201130338.q0D3cMgJ018062@repoman.freebsd.org> <201201161838.12941.makc@freebsd.org> <4F1472E7.3010309@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Max Brazhnikov , Axel Gonzalez , cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 19:12:49 -0000 Veniamin Gvozdikov wrote on 16.01.2012 23:04: > I'm agree. > > 2012/1/16 Ruslan Mahmatkhanov: >> Max Brazhnikov wrote on 16.01.2012 22:38: >>>> Log: >>>> - let it build with stock gcc >>>> - optionify ipod and mtp support (default on) >>> >>> >>> This type of `port optionification' leads to a nasty problem of hidden >>> dependencies when options are unchecked, but corresponding libraries are >>> presented. Please consider to commit the patch, which makes optional >>> support >>> really optional. >>> >>> Max >> >> >> You are right, thank you. >> Veniamin, do you have any objections if this patch will be committed? Committed, thank you! -- Regards, Ruslan Tinderboxing kills... the drives.