From owner-cvs-ports@FreeBSD.ORG  Fri May 21 06:28:26 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 64D821065675;
	Fri, 21 May 2010 06:28:26 +0000 (UTC)
	(envelope-from magik@roorback.net)
Received: from roorback.net (roorback.net [204.109.63.52])
	by mx1.freebsd.org (Postfix) with ESMTP id 405AE8FC1E;
	Fri, 21 May 2010 06:28:26 +0000 (UTC)
Received: from mx.roorback.net (localhost [127.0.0.1])
	by roorback.net (Postfix) with ESMTPSA id 302B817126;
	Fri, 21 May 2010 08:11:13 +0200 (CEST)
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Date: Fri, 21 May 2010 08:11:13 +0200
From: Grzegorz Blach <magik@roorback.net>
To: <QAT@FreeBSD.org>
In-Reply-To: <20100521000020.A2CBB5A9056@jester1b.ixsystems.com>
References: <201005202124.o4KLOlL3099883@repoman.freebsd.org>
	<20100521000020.A2CBB5A9056@jester1b.ixsystems.com>
Message-ID: <94bdaf7d3141b6f715fc271907237626@roorback.net>
X-Sender: magik@roorback.net
User-Agent: RoundCube Webmail/0.4-beta
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
	autolearn=unavailable version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on roorback.net
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.5
	(roorback.net); Fri, 21 May 2010 08:11:42 +0200 (CEST)
Cc: cvs-ports@FreeBSD.org, pav@FreeBSD.org, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/weave Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 May 2010 06:28:26 -0000

On Thu, 20 May 2010 17:00:19 -0700 (PDT), QAT@FreeBSD.org wrote:
> The Restless Daemon identified a coredump error while trying to build:
>  weave-1.2.3,2 maintained by magik@roorback.net
>  Makefile ident: $FreeBSD: ports/www/weave/Makefile,v 1.16 2010/05/20
>  21:24:47 pav Exp $
> 
> Excerpt from http://QAT.TecNik93.com/logs/8-STABLE-NPD/weave-1.2.3,2.log
:


I don't try to build current version of weave,
but this log looks like, building was broken by recent patch for weave.

@@ -59,7 +59,7 @@ PLIST_SUB+=	XPI_XPIDIR="${XPI_DIR:S,^${P
 
 post-patch:
 	@${REINPLACE_CMD} -e "s|\$$(shell hg tip --template
'{node\|short}')|${REVID}|g" ${WRKSRC}/Makefile
-.if ${PLATFORM} == FreeBSD_x86_64-gcc3
+.if ${ARCH} == amd64
 	${REINPLACE_CMD} -e 's|arch = amd64|arch = x86_64|g'
${WRKSRC}/crypto-obsolete/src/Makefile
 .endif


Reinplace that change arch = amd64 to arch = x86_64, should be applied
only when ${WITH_FF35} is set.
I used .if ${PLATFORM} == FreeBSD_x86_64-gcc3, because this is equal only
for ${WITH_FF35} == true && ${ARCH} == amd64,
But using .if ${WITH_FF35} == true (without ${ARCH} comparison) will work
too,
beacause this patch don't change anything on i386 platform, for both
version of Firefox.


So pav, in the future please send me a patches for review.