Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Apr 2004 10:32:14 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/pci pci.c pci_pci.c pci_private.h      src/sys/dev/acpica acpi_pci.c acpi_pcib_acpi.c
Message-ID:  <20040409102752.T48723@root.org>
In-Reply-To: <20040409154449.4EBD616A4F2@hub.freebsd.org>
References:  <20040409154449.4EBD616A4F2@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 9 Apr 2004, Warner Losh wrote:
> imp         2004/04/09 08:44:34 PDT
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/pci          pci.c pci_pci.c pci_private.h
>     sys/dev/acpica       acpi_pci.c acpi_pcib_acpi.c
>   Log:
>   Omnibus PCI commit:
>           o Save and restore bars for suspend/resume as well as for D3->D0
>             transitions.
>           o preallocate resources that the PCI devices use to avoid resource
>             conflicts
>           o lazy allocation of resources not allocated by the BIOS.
>           o set unattached drivers to state D3.  Set power state to D0
>             before probe/attach.  Right now there's two special cases
>             for this (display and memory devices) that need work in other
>             areas of the tree.
>
>   Please report any bugs to me.
>
>   Revision  Changes    Path
>   1.11      +2 -2      src/sys/dev/acpica/acpi_pci.c
>   1.31      +22 -1     src/sys/dev/acpica/acpi_pcib_acpi.c
>   1.238     +294 -58   src/sys/dev/pci/pci.c
>   1.31      +2 -2      src/sys/dev/pci/pci_pci.c
>   1.12      +2 -0      src/sys/dev/pci/pci_private.h

And there was dancing in the streets!  And then once reality set in, much
fear and trembling.

> +struct resource *
> +acpi_pcib_acpi_alloc_resource(device_t dev, device_t child, int type, int *rid,
> +  u_long start, u_long end, u_long count, u_int flags)
> +{
> +	/*
> +	 * If no memory preference is given, use upper 256MB slot most
> +	 * bioses use for their memory window.  Typically other bridges
> +	 * before us get in the way to assert their preferences on memory.
> +	 * Hardcoding like this sucks, so a more MD/MI way needs to be
> +	 * found to do it.
> +	 */
> +	if (type == SYS_RES_MEMORY && start == 0UL && end == ~0UL)
> +		start = 0xf0000000;
> +	return (bus_generic_alloc_resource(dev, child, type, rid, start, end,
> +	    count, flags));
>  }

Email me about this, it may be solvable with sysresource.

Thank you!!!

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040409102752.T48723>