From owner-freebsd-current@FreeBSD.ORG  Thu Jul  5 11:58:19 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B532616A46B;
	Thu,  5 Jul 2007 11:58:19 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 2353E13C46E;
	Thu,  5 Jul 2007 11:58:18 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l65BwHHV050866;
	Thu, 5 Jul 2007 15:58:17 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru;
	s=default; t=1183636697; bh=EcMHuARjpT0RWqwhQuzc96gY8UZNAx0uiRRwlTT
	qsVY=; l=663; h=Received:Date:From:To:Cc:Subject:Message-ID:
	Mail-Followup-To:References:MIME-Version:Content-Type:
	Content-Disposition:In-Reply-To:User-Agent; b=p5Wngjq6rvUyrquYKDoV
	+t6yFj5YJ+0Kh7YDmmbmmeul9qX66zeNPCtvu4eYgCzY1483YLcgM6BEF840hmLOXSx
	KaZ8bGtEzwLQLOWAzNEDPK7GC3IQ+KyJhq6/J0nb9OWCsxprrOVACthjAvZg+czlcJb
	Wd2dcsjdNMs5+yMPo=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id l65BwHH9050863;
	Thu, 5 Jul 2007 15:58:17 +0400 (MSD) (envelope-from ache)
Date: Thu, 5 Jul 2007 15:58:16 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: "Sean C. Farley" <scf@FreeBSD.org>
Message-ID: <20070705115816.GA50506@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	"Sean C. Farley" <scf@FreeBSD.org>,
	Robert Watson <rwatson@FreeBSD.org>,
	freebsd-current <freebsd-current@FreeBSD.org>,
	Michal Mertl <mime@traveller.cz>
References: <20070704143642.GA31254@nagual.pp.ru>
	<20070704150312.GB31683@nagual.pp.ru>
	<20070704101026.O77978@thor.farley.org>
	<20070704173905.T67251@fledge.watson.org>
	<20070704121316.A77978@thor.farley.org>
	<20070704180000.GA34042@nagual.pp.ru>
	<20070704144159.X77978@thor.farley.org>
	<20070704195939.GA35302@nagual.pp.ru>
	<20070704235630.GA42227@nagual.pp.ru>
	<20070704215154.O77978@thor.farley.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070704215154.O77978@thor.farley.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: freebsd-current <freebsd-current@FreeBSD.org>,
	Robert Watson <rwatson@FreeBSD.org>, Michal Mertl <mime@traveller.cz>
Subject: Re: Environment handling broken in /bin/sh with changes to
	{get,set,put}env()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jul 2007 11:58:19 -0000

On Wed, Jul 04, 2007 at 09:53:15PM -0500, Sean C. Farley wrote:
> The latest patch at the same URL fixes that issue.  It basically
> deactivates all existing variables and inserts the new environ variables
> into the envVars array.

Calling __clean_env(false) is good but the rest looks like a bit overkill.

Previously the goal of veryfy_env() is just deactivate, the goal of 
build_env() is just build. It was build_env() who insetrts new environ 
variables into envVars array in old variant, isn't?

Now verify_env() takes the role of build_env() too, moreover, may cause 
setenv() to be called recursively which isn't good.

-- 
http://ache.pp.ru/