Date: Mon, 30 Dec 2013 20:48:37 GMT From: Xin LI <delphij@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: portmgr@FreeBSD.org Subject: ports/185309: [PATCH] Mk/bsd.port.mk: add generic INSTALL_STRIPPED option for use with WITH_DEBUG Message-ID: <201312302048.rBUKmboh094202@freefall.freebsd.org> Resent-Message-ID: <201312302050.rBUKo1um094321@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 185309
>Category: ports
>Synopsis: [PATCH] Mk/bsd.port.mk: add generic INSTALL_STRIPPED option for use with WITH_DEBUG
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Dec 30 20:50:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Xin LI
>Release: FreeBSD 11.0-CURRENT amd64
>Organization:
iXsystems, Inc.
>Environment:
System: FreeBSD freefall.freebsd.org 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r259961: Fri Dec 27 21:56:39 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64
>Description:
(Note that this patch is from Alfred Perlstein).
This proposed bsd.port.mk change adds a new option, INSTALL_STRIPPED,
which is intended to be used with WITH_DEBUG, allowing the system to build
packages with debugging symbols enabled and kept in build environment but
do not install them with the resulting binaries.
>How-To-Repeat:
>Fix:
--- bsd.port.mk.diff begins here ---
Index: Mk/bsd.port.mk
===================================================================
--- Mk/bsd.port.mk (revision 337471)
+++ Mk/bsd.port.mk (working copy)
@@ -1318,7 +1318,7 @@ WITH_DEBUG= yes
.endif
# Reset value from bsd.own.mk.
-.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG)
+.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) && !defined(INSTALL_STRIPPED)
STRIP= #none
.endif
@@ -1617,7 +1617,9 @@ CFLAGS:= ${CFLAGS:C/${_CPUCFLAGS}//}
.endif
.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG)
+.if !defined(INSTALL_STRIPPED)
STRIP_CMD= ${TRUE}
+.endif
DEBUG_FLAGS?= -g
CFLAGS:= ${CFLAGS:N-O*:N-fno-strict*} ${DEBUG_FLAGS}
.endif
--- bsd.port.mk.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312302048.rBUKmboh094202>