Date: Sun, 5 Apr 2020 21:32:13 -0600 From: Adam Weinberger <adamw@adamw.org> To: "Danilo G. Baio" <dbaio@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r530850 - head/sysutils/duplicity Message-ID: <CAP7rwcjdUkdEXrLARW30UearjWtq1CdRCXXhuL_Ce4dS3aqkSw@mail.gmail.com> In-Reply-To: <202004060027.0360RGEi071351@repo.freebsd.org> References: <202004060027.0360RGEi071351@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 5, 2020 at 6:28 PM Danilo G. Baio <dbaio@freebsd.org> wrote: > > Author: dbaio > Date: Mon Apr 6 00:27:15 2020 > New Revision: 530850 > URL: https://svnweb.freebsd.org/changeset/ports/530850 > > Log: > sysutils/duplicity: Fix build when NLS option is off > > Reported by: filis > MFH: 2020Q2 (build blanket) > > Modified: > head/sysutils/duplicity/Makefile > > Modified: head/sysutils/duplicity/Makefile > ============================================================================== > --- head/sysutils/duplicity/Makefile Mon Apr 6 00:17:34 2020 (r530849) > +++ head/sysutils/duplicity/Makefile Mon Apr 6 00:27:15 2020 (r530850) > @@ -65,7 +65,7 @@ post-patch: > .endfor > > post-patch-NLS-off: > - @${REINPLACE_CMD} -e '55,63d' \ > + @${REINPLACE_CMD} -e '105,129d' \ > ${WRKSRC}/setup.py Thanks for fixing that, Danilo. This is probably the prime example of when REINPLACE_CMD is the wrong tool for the job. The command succeeds, even if it breaks the entire build. This is probably better done as a patch. I mention this to highlight an ongoing problem that we're trying to sort out, not to suggest that it's your responsibility to fix it. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcjdUkdEXrLARW30UearjWtq1CdRCXXhuL_Ce4dS3aqkSw>